Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Op info test for linalg.norm .. linalg.solve #7503

Closed
qihqi opened this issue Jun 25, 2024 · 1 comment · Fixed by #8044
Closed

Op info test for linalg.norm .. linalg.solve #7503

qihqi opened this issue Jun 25, 2024 · 1 comment · Fixed by #8044
Assignees
@qihqi @yenkwang
Labels
good first issue Good for newcomers torchxla2

Comments

@qihqi
Copy link
Collaborator

qihqi commented Jun 25, 2024

Fix the Op info test for linalg.norm .. linalg.solve

  1. Find the lines 133 to 137 of test_ops.py and remove
    linalg.norm .. linalg.solve from skip_list
  2. Run op_info test with pytest test/test_ops.py
  3. Fix the failure.

Please refer to
this guide as guide to fix:

Also refer to these PRs:
@qihqi qihqi added good first issue Good for newcomers torchxla2 labels Jun 25, 2024
@yenkwang yenkwang self-assigned this Sep 9, 2024
yenkwang added a commit to yenkwang/xla that referenced this issue Sep 13, 2024
@yenkwang
Op info test for logdet, linalg.slogdet (pytorch#7503) (pytorch#7958)
79fab34
ManfeiBai pushed a commit that referenced this issue Sep 13, 2024
@yenkwang
Op info test for logdet, linalg.slogdet (#7503) (#7958) (#8004)
3a9f53f
@ManfeiBai
Copy link
Collaborator

Hi, @yenkwang, thanks for contribution!

please feel free to push commit to PR and test with CI too

yenkwang added a commit to yenkwang/xla that referenced this issue Sep 19, 2024
@yenkwang
Op info test for linalg.norm, linalg.pinv, linalg.solve (pytorch#7503)
03b04c3
@yenkwang yenkwang linked a pull request Sep 19, 2024 that will close this issue
Op info test for linalg.norm, linalg.pinv, linalg.solve (#7503) #8044
Merged
ManfeiBai pushed a commit that referenced this issue Sep 19, 2024
@yenkwang
Op info test for linalg.norm, linalg.pinv, linalg.solve (#7503) (#8044)
441098b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qihqi qihqi

@yenkwang yenkwang

Labels
good first issue Good for newcomers torchxla2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Op info test for linalg.norm, linalg.pinv, linalg.solve (#7503) yenkwang/xla
3 participants
@qihqi @ManfeiBai @yenkwang