-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
video.json schema should not allow additional properties #1173
Comments
jonafato
added a commit
that referenced
this issue
Jul 28, 2024
The intent of this change is to update the schema without any test failures. This means that other changes that affect the data should happen independently from the pull request associated with this commit, and it should be kept up to date and merged once the schema tests pass. To contribute to this change, open PRs that would correct any data that does not conform to the JSON schema. Discussion regarding other schema updates should happen in the associated issue at #1173. Resolves #1173.
This was referenced Jul 28, 2024
jonafato
added a commit
that referenced
this issue
Aug 3, 2024
The intent of this change is to update the schema without any test failures. This means that other changes that affect the data should happen independently from the pull request associated with this commit, and it should be kept up to date and merged once the schema tests pass. To contribute to this change, open PRs that would correct any data that does not conform to the JSON schema. Discussion regarding other schema updates should happen in the associated issue at #1173. Resolves #1173.
jonafato
added a commit
that referenced
this issue
Aug 13, 2024
The intent of this change is to update the schema without any test failures. This means that other changes that affect the data should happen independently from the pull request associated with this commit, and it should be kept up to date and merged once the schema tests pass. To contribute to this change, open PRs that would correct any data that does not conform to the JSON schema. Discussion regarding other schema updates should happen in the associated issue at #1173. Resolves #1173.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The video schema currently allows additional properties on video data, but these attributes are not used by the website (and cannot be used without first being validated by the schema). The schema should disallow this, which will require first removing unneeded data from video files or moving data into a more correct field (e.g. see https://github.com/pyvideo/data/tree/main/writethedocs-au-2018 for an example of data that is present in an "abstract" field but should be in the "description" field instead).
The text was updated successfully, but these errors were encountered: