Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicting flags do not raise an error or warning. #36

Open
AlejandroFernandezLuces opened this issue Jan 18, 2023 · 1 comment
Open

Conflicting flags do not raise an error or warning. #36

AlejandroFernandezLuces opened this issue Jan 18, 2023 · 1 comment
Assignees
@AlejandroFernandezLuces

Comments

@AlejandroFernandezLuces
Copy link
Collaborator

The flags --fail_extra_image_cache and --add_missing_images are incompatible with each other. This is not documented anywhere. We should:

  • Update the documentation to cover this.
  • Choose what flag will take priority in case of conflict.
  • Raise a warning in the code to notify that both flags are incompatible when both flags are active, and tell the user which one is prioritized.
Merged
@MatthewFlamm
Copy link
Contributor

MatthewFlamm commented Jan 29, 2023 •
edited
Loading

I think it would better to have the default to fail on extra images. Then options like add-missing-images and so on would modify this behavior. Is there any scenario we'd want to have a passing test with extra images created without these other flags in use?

@MatthewFlamm MatthewFlamm mentioned this issue Jan 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlejandroFernandezLuces AlejandroFernandezLuces

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlejandroFernandezLuces @MatthewFlamm