Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI arguments are not aligned with Pytest arguments style #94

Open
germa89 opened this issue Oct 2, 2023 · 2 comments
Open

CLI arguments are not aligned with Pytest arguments style #94

germa89 opened this issue Oct 2, 2023 · 2 comments

Comments

@germa89
Copy link
Contributor

germa89 commented Oct 2, 2023

Pytest arguments replace the spaces by minus (-) when defining arguments. For example:

pytest --durations=10 --durations-min=1.0

https://docs.pytest.org/en/6.2.x/usage.html#profiling-test-execution-duration

whereas in pytest-pyvista all the arguments are separated by "_".

This is a minor thing. But I just wanted to highlight it for consistency.

@germa89
Copy link
Contributor Author

germa89 commented Oct 2, 2023

Mmhh... the fault handler also uses "_" so ... feel free to close if you feel like it.

https://docs.pytest.org/en/6.2.x/usage.html#fault-handler

@MatthewFlamm
Copy link
Contributor

I have no strong opinion. The most important thing is to be consistent within this package and not mix the usage. Let's leave open to see if anyone has a strong opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants