Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching of images is always JPEG format, PNG is neglected. #795

Open
q2apro opened this issue Feb 11, 2020 · 2 comments
Open

Caching of images is always JPEG format, PNG is neglected. #795

q2apro opened this issue Feb 11, 2020 · 2 comments

Comments

@q2apro
Copy link

q2apro commented Feb 11, 2020 •
edited
Loading

See \qa-include\qa-image.php and \db\cache.php - their caching always defaults to JPEG.

However, doing so, the transparency channel gets of uploaded user avatars in PNG gets lost.
@svivian
Copy link
Collaborator

svivian commented May 6, 2020

Interesting problem... I think avatar uploads are set to JPG to avoid people uploading a photo in PNG format, which would have a much larger file size than JPG. Also JPG can use lower quality settings. Perhaps for avatars it is less of an issue though.

@q2apro
Copy link
Author

q2apro commented May 12, 2020

This should definitely use PNG and JPG. Especially PNG transparency is important for proper display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svivian @q2apro