Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to check pull request analysis #8

Open
YotillaJonas opened this issue Jan 27, 2021 · 2 comments
Open

Allow to check pull request analysis #8

YotillaJonas opened this issue Jan 27, 2021 · 2 comments
Assignees
@phxql
Labels
enhancement New feature or request

Comments

@YotillaJonas
Copy link

The sonarQube pull request analysis uses the following parameters which would need to be checked:

  • sonar.pullrequest.key
  • sonar.pullrequest.branch
  • sonar.pullrequest.base
@phxql
Copy link
Contributor

phxql commented Jan 28, 2021

Will look into it.

@phxql phxql self-assigned this Jan 28, 2021
@phxql phxql added the enhancement New feature or request label Jan 28, 2021
@phxql
Copy link
Contributor

phxql commented Mar 8, 2021

We need to add pullRequest parameter to GET api/qualitygates/project_status which is the "Pull request id" according to documentation. When scanning, this PR key is set via sonar.pullrequest.key. The branch parameter has to be set to the branch in which the PR resides. When scanning, this PR branch is set via sonar.pullrequest.branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phxql phxql

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phxql @YotillaJonas