feat: Add a GetPicutreCells function #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuri
added
the
size/L
|
I could really use this functionality as well! |
|
When will this commit can be merged? 🤣 |
|
Thanks for your pull request. I need some time to review. |
xuri
requested changes
Oct 12, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #1634 +/- ##
==========================================
+ Coverage 98.99% 99.02% +0.02%
==========================================
Files 32 32
Lines 27587 27641 +54
==========================================
+ Hits 27311 27371 +60
+ Misses 183 179 -4
+ Partials 93 91 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
xuri
approved these changes
Oct 12, 2023
xuri
changed the title
jenbonzhang
pushed a commit
to jenbonzhang/excelize
that referenced
this pull request
Oct 22, 2023
- Introduce new exported function GetPictureCells - Upgrade dependencies module golang.org/x/net from 0.16.0 to 0.17.0 - Update unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
When I import an xlsx, I need to go through all the cells to get the pictures, each call to the getPicture function traverses all the pictures, why not just provide a way to get all the pictures at once.
Related Issue
Motivation and Context
How Has This Been Tested
Types of changes
Checklist