Make smart ban optional

[HanabishiRecca]

Suggestion

Currently, qBittorrent enables libtorrent's smart ban plugin unconditionally. It automatically bans peers sending corrupted pieces.

qBittorrent/src/base/bittorrent/sessionimpl.cpp

Line 1698 in 7487cd7

m_nativeSession->add_extension(&lt::create_smart_ban_plugin);

So maybe it is a good idea to make it optional. A simple checkbox in advanced settings would suffice, I think.

Use case

Some users claim that there are use cases when it is undesirable behavior.
Like downloading a rare torrent with only 1 seed with unstable connection. Any traffic overhead in such situation is justified.

Extra info/examples/attachments

No response

[HanabishiRecca]

Hmm, turns out the smart ban plugin is not the only mechanism for banning peers.
Libtorrent also has internal torrent::penalize_peers method which does basically the same thing anyway.
I don't know why there are two different mechanisms for that, but it makes this request kinda irrelevant.

[mirh]

#15193 being a clear example of why this wouldn't hurt

[stalkerok]

@mirh It has nothing to do with that. Besides, the issue with archive.org torrents is solely an issue with archive.org itself, and has nothing to do with qBittorrent.

[mirh]

I mean, my log showed:

02/01/2025 19:12 - URL seed DNS lookup failed. Torrent: "archiveteam_archivebot_go_falconk_forum_bioware_com_20160730". URL: "http://ia600500.us.archive.org". Error: "archiveteam_archivebot_go_falconk_forum_bioware_com_20160730 url seed (http://ia600500.us.archive.org) failed: peer banned"

[HanabishiRecca]

Yeah, that looks to be it. Although, as I already said above

turns out the smart ban plugin is not the only mechanism for banning peers

So automatic bans can't be disabled completely on qBittorrent side.

[HanabishiRecca]

URL seed DNS lookup failed.

Btw, this message is wrong actually. Your error has absolutely nothing to do with DNS.

qBittorrent/src/base/bittorrent/sessionimpl.cpp

Lines 5968 to 5970 in 6fe0289

	LogMsg(tr("URL seed DNS lookup failed. Torrent: \"%1\". URL: \"%2\". Error: \"%3\"")
	.arg(torrent->name(), QString::fromUtf8(alert->server_url()), QString::fromStdString(alert->message()))
	, Log::WARNING);

It assumes that all possible web seed errors could be from DNS lookup only. Which is simply not true as we can see.

The message probably should be replaced by something neutral, like URL seed connection failed. @glassez