Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with frictionless primaryKey and foreignKey validation #1009

Open
ghost opened this issue May 10, 2020 · 0 comments
Open

Align with frictionless primaryKey and foreignKey validation #1009

ghost opened this issue May 10, 2020 · 0 comments

Comments

@ghost
Copy link

ghost commented May 10, 2020

Some time ago, when implementing foreign keys (and primary keys) from spec, the relevant frictionless libraries hadn't fully implemented validation by foreign keys.
It's worth looking at where this is and replace equivalent function in Data Curator (1 less part to maintain).
Also align naming of primaryKey (in DC property name is primaryKeys). For keeping up with changes to what is available in schema, it is simpler to iterate properties from frictionless without having to know what they are, rather than explicitly naming them every time we export (atm Import does exactly this ie: it doesn't name these, it just defers to frictionless for these to populate DC store- so removes the need to keep up-to-date with any new schema property additions/changes as it will always come from their schema (published under 'lib' atm in relevant library as json)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants