Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open data package .zip from local drive opens additional tab #1020

Open
Stephen-Gates opened this issue May 18, 2020 · 1 comment
Open

Open data package .zip from local drive opens additional tab #1020

Stephen-Gates opened this issue May 18, 2020 · 1 comment

Comments

@Stephen-Gates
Copy link
Contributor

Screenshot 2020-05-18 18 31 46

Current Behaviour (for problems)

When I open a data package zip file from my local drive, everything appears to work fine however an extra empty tab that was not in the package is displayed

Your Environment

  • Data Curator version: 1.2.0 alpha
  • Operating System and version: macOS 10.15.4
@ghost
Copy link

ghost commented May 18, 2020

Hi @Stephen-Gates
You might recall at the time we did this we made the decision not to overwrite existing tabs in case the user had data already there. The open package opens a new tab for each resource rather than re-using any existing opened tabs.
The other behaviour, probably as/more important, there's no action like this that resets everything to 0, including the package, table and column properties. It might be that these properties are overwritten anyway as the open package/resources fills out properties, but there is no deliberate reset behaviour before this 'open' begins. I've noticed that this might also be handy even if the user decides not to import or export anything, but simply wants to start again (without having to close and start the app again).
I guess if this was to be put in as an enhancement we could have some behaviour to toggle this on/off. Something like, "On opening a data package":

  • keep existing tabs and open a new tab for each new resource (existing behaviour)
  • prompt to save and then start at beginning, resetting all properties to blank or equivalent, resetting the Tab counter to 0 and open each resource beginning with Tab 1 again as the app would do on first opening
  • (maybe through use of toggle between last point and this one) don't prompt: perform the reset behaviour described above, overwriting everything, any time the user opens a package.
    Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant