Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid private api #3

Open
nyalldawson opened this issue Dec 28, 2020 · 0 comments
Open

Avoid private api #3

nyalldawson opened this issue Dec 28, 2020 · 0 comments

Comments

@nyalldawson
Copy link

The test https://github.com/qcooperative/qgis-core-tests/blob/master/coretests/tests/testerplugin.py#L59 relies on non-stable, private api here: https://github.com/qcooperative/qgis-core-tests/blob/master/coretests/tests/testerplugin.py#L123

This should be removed, as it could validly break in any future qgis release (it's not stable api).

More generally, I don't think it's a good idea to try to automate parts of the test like opening the dialog for users. To me this needlessly restricts the actual scope of test -- instead of the batch test also covering things like testing that users can search for an algorithm in the toolbox and testing that selecting the batch option correctly opens the batch dialog without issue, we're instead skipping a bunch of these useful tests! So by trying to be helpful, we're ending up with a less valuable test all round...

For this reason, I'd suggest we ONLY automate steps which are absolutely critical, and leave everything else as manual steps for users to do themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant