Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method naming inconsistency - Recommendation API #53

Open
kacperlukawski opened this issue Oct 27, 2023 · 2 comments
Open

Method naming inconsistency - Recommendation API #53

kacperlukawski opened this issue Oct 27, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@kacperlukawski
Copy link
Member

The recommend_batch method of the QdrantClient is inconsistent with the other methods. It should be renamed to recommendBatch, with keeping recommend_batch as an alias.
@kacperlukawski kacperlukawski added the good first issue Good for newcomers label Oct 27, 2023
@kacperlukawski kacperlukawski changed the title Method naming inconsistency Method naming inconsistency - Recommendation API Oct 27, 2023
@Morad-m11
Copy link
Contributor

#54. First contribution, appreciate any feedback

@ryuusama09
Copy link

Is the issue still open ? . I would like to give a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kacperlukawski @ryuusama09 @Morad-m11