New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambigous OurViewChange ActiveLeavesUpdate #2353

Open

turuslan opened this issue Jan 27, 2025 · 0 comments

Contributor

turuslan commented Jan 27, 2025 •

edited

Loading

#2354 will only fix ViewUpdate,
it won't change anything else

OurViewChange is limited to MAX_VIEW_HEADS = 5
in kagome OurViewChange can be confused with ActiveLeavesUpdate
in rust OurViewChange is used in several places:
- send ViewUpdate after handshake and on change
- (backing?) "polkadot/node/network/collator-protocol/src/validator_side/mod.rs" ("parachain_processor.cpp")
- bitfield distribution "polkadot/node/network/bitfield-distribution/src/lib.rs"
  - incoming message in "our_view.heads"
- approval distribution "polkadot/node/network/approval-distribution/src/lib.rs"
  - incoming messages is pending if in "out_view.heads" else circulated
- NOT used by statement distribution (uses ActiveLeavesUpdate)

TODO: check rust, do forks pruned by finalization cause ActiveLeavesUpdate?

The text was updated successfully, but these errors were encountered:

turuslan mentioned this issue

fix ViewUpdate #2354

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment