login fail !!!!

[dmitryshelomanov]

this.login = function (username, password, callback) {
        var self = this;
        this.rocketChatClient.authentication.login(username, password, function (err, body) {
            
            self.token = body.data;
            callback(null, body);
        });
    };

no handle error !!! App crashed

[ShoaibCubix]

Call it as rocketChatApi.login(username, password, function(err,body){
if(err)
console.log(err);
else
console.log(body);
})

[dmitryshelomanov]

@ShoaibCubix
this

this.login = function (username, password, callback) {
        var self = this;
        this.rocketChatClient.authentication.login(username, password, function (err, body) {
            
            self.token = body.data;
            callback(null, body);
        });
    };

not my code. Error not handle. When error and body === null -> self.token = body.data (this crash)

[ShoaibCubix]

Yeah you are right

[dmitryshelomanov]

@ShoaibCubix you make fix ?

[ShoaibCubix]

@userbq201 Not yet. Busy with job.

[dmitryshelomanov]

@ShoaibCubix ok. I opened PR