Loading the thumbnail_full in preview #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ismailsunni |
ismailsunni
reviewed
Jul 31, 2023
There was a problem hiding this comment.
I tested it, and it's working fine and the preview looks better.
Unfortunately, the performance is slightly down for some resources with big file-size thumbnails (slower to show the preview).
Some options:
- Add a loading icon when the full thumbnail is not fully downloaded
- Download the full thumbnail in the background
- Add an option in the setting to select which thumbnail to be shown (full or cropped)
1 and 2 are similar but more complicated and need #44. So, let's implement the 3rd one.
Note: I got a QGIS crash when I played with it, not sure with which resource though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the thumbnail_full to load the preview image.
Some thumbnail_full resources are not downloaded properly: eg: QGIS Dashboard
And the thumbnails are not properly aligned in the center