Refactor QgsConnectionPool[Group] and it's descendants

[reflectored]

Description

This refactoring job is related to qgis/QGIS-Enhancement-Proposals#272 and the original pull request for the AWS Redshift driver #53018.

• Move qgsConnectionPool_[connectionCreate|connectionDestroy|invalidateConnection|connectionIsValid|connectionToName] into their appropriate abstract classes and declare them as pure virual.
• Implement the destructor and the functions above for all providers.
• Refactor QgsPostgresConnPool[Group] to QgsSQLConnPool[Group], in order to reuse the template for future SQL based providers (AWS Redshift).
• Refactor Postgres connection settings to use the latest settings API.

[reflectored]

@nyalldawson @jef-n I started the refactoring work we have discussed. I noticed some redundant code with the connection pool so I started here.

[elpaso]

Thank you for working on this refactoring, it was definitely time to do it.

[reflectored]

@elpaso thanks for the review, I have addressed all of your comments!

[reflectored]

@elpaso not sure if the spell_check error is related. Would you mind taking another look?

[elpaso]

@elpaso not sure if the spell_check error is related. Would you mind taking another look?

Looks good to me, I'll try to restart the failing jobs, sometimes it helps (even if it shouldn't).

[3nids]

My preferred approach would indeed be the duplication of the settings. Indeed chances of divergence are there and it's better isolated and also avoid the need for the dynamic naming.

[reflectored]

Also, my solution did not work for the tests and mingw build, the same QgsSettingsException was thrown during the provider test runs - resolved to normal settings class.

[reflectored]

@3nids something seems off with the CI, when I run locally the tests e.g. ALL_BUT_PROVIDERS, I do not hit these failures anymore on my latest patch (due to QgsSettingsException). Only some flaky tests fail for other reasons:

98% tests passed, 18 tests failed out of 855

Label Time Summary:
POSTGRES    =   8.31 sec*proc (3 tests)

Total Test time (real) = 2632.87 sec

The following tests FAILED:
	  2 - checkGitStatus (Failed)
	 35 - test_core_authmanager (Failed)
	135 - test_core_networkaccessmanager (Subprocess aborted)
	222 - test_core_openclutils (Subprocess aborted)
	278 - test_gui_filedownloader (Subprocess aborted)
	296 - test_gui_queryresultwidget (Subprocess aborted)
	300 - test_3d_3drendering (Failed)
	324 - test_analysis_processing (Failed)
	328 - test_provider_wcsprovider (Failed)
	482 - PyQgsExternalStorageWebDav (Failed)
	483 - PyQgsExternalStorageAwsS3 (Failed)
	600 - PyQgsMapLayerComboBox (Failed)
	603 - PyQgsMapLayerProxyModel (Failed)
	664 - PyQgsProcessExecutablePt1 (Failed)
	665 - PyQgsProcessExecutablePt2 (Failed)
	769 - PyQgsStyleModel (Failed)
	852 - qgis_sipify (Failed)
	854 - qgis_sip_uptodate (Failed)
Errors while running CTest
Output from these tests are in: /home/qgis/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.

Also I struggle to get a container for the MinGW working, I tried manually running on fedora:rawhide, but then the NodeJS version there is too new for the current configurations. Do you have a particular container for MinGW at hand? Got to reproduce the build failure for MinGW, it is missing symbols for PostgreSqlConnectionSettings - I'm investigating.

[3nids]

on the settings front, everything looks good!
thanks a lot for the changes.

[reflectored]

@elpaso it passes all tests now! I appreciate your review.

[reflectored]

ping @elpaso

[elpaso]

ping @elpaso

Sorry for the late reply, can you please resolve the merge conflicts?

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[github-actions]

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.