Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor QgsConnectionPool[Group] and it's descendants #53307

Closed
wants to merge 4 commits into from
Closed

Refactor QgsConnectionPool[Group] and it's descendants #53307

wants to merge 4 commits into from

Commits on Jul 31, 2023

  1. This refactoring job is related to qgis/QGIS-Enhancement-Proposals#272 … 

    …and the original pull request for the AWS Redshift driver qgis#53018.

  - Move qgsConnectionPool_[connectionCreate|connectionDestroy|invalidateConnection|connectionIsValid|connectionToName] into their appropriate abstract classes and declare them as pure virual.
  - Implement the destructor and the functions above for all providers.
  - Refactor QgsPostgresConnPool[Group] to QgsSQLConnPool[Group], in order to reuse the template for future SQL based providers (AWS Redshift).
    Alexey Karandashev committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    843fe3e View commit details
    Browse the repository at this point in the history

  2. Refactor PGException and QgsPostgresResult

    Alexey Karandashev committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    45792e4 View commit details
    Browse the repository at this point in the history

  3. Refactor ConnectionConfigurator out of PostgresConn.

    Alexey Karandashev committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    7efdafa View commit details
    Browse the repository at this point in the history

  4. remove QgsPoolPostgresConn and move connection pointer ownership to Q… 

    …gsSQLConnPool
    Alexey Karandashev committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    0278920 View commit details
    Browse the repository at this point in the history