Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contextDiff test failure #12

Open
unsaved opened this issue Oct 18, 2021 · 1 comment
Open

contextDiff test failure #12

unsaved opened this issue Oct 18, 2021 · 1 comment

Comments

@unsaved
Copy link

unsaved commented Oct 18, 2021

Insertion of line at index 19 is totally missed by the comparison:

#!/usr/bin/env node

const difflib = require("difflib");

const origLines =
    ["zero", "one", "two", "three", "four", "five", "six",
     "seven", "eight", "nine", "ten", "eleven",
    "twelve", "thirteen", "fourteen", "fifteen",
    "sixteen", "seventeen", "eighteen", "nineteen"];
const newLines = origLines.slice();
newLines.splice(19, 0, "newteen");
newLines[10] = "changed";
newLines.splice(3, 1);

console.log("Orig: " + origLines);
console.log("New: " + newLines);
console.log(difflib.contextDiff(origLines, newLines,
    { fromfile: "LHS", tofile: "RHS", n: 2, lineterm: "" }
).join("\n"));
@unsaved
Copy link
Author

unsaved commented Oct 18, 2021

After editing "difflib.js" to pass n to getGroupedOpcodes to work around Issue #8, the contextDiff output now also misses the change of element at index 10 from "nine" to "changed".

#!/usr/bin/env node

const difflib = require("difflib");

const origLines =
    ["zero", "one", "two", "three", "four", "five", "six",
     "seven", "eight", "nine", "ten", "eleven",
    "twelve", "thirteen", "fourteen", "fifteen",
    "sixteen", "seventeen", "eighteen", "nineteen"];
const newLines = origLines.slice();
newLines.splice(19, 0, "newteen");
newLines[10] = "changed";
newLines.splice(3, 1);

console.log("Orig: " + origLines);
console.log("New: " + newLines);
console.log(difflib.contextDiff(origLines, newLines,
    { fromfile: "LHS", tofile: "RHS", n: 2, lineterm: "" }
).join("\n"));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant