From 65b904cf7c2b5965b6d5b40284a5cdb810fbc46b Mon Sep 17 00:00:00 2001 From: Andrea Date: Wed, 20 Dec 2023 17:48:29 +0100 Subject: [PATCH 1/2] fix: fix rabi correction formula --- src/qibocal/protocols/characterization/rabi/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qibocal/protocols/characterization/rabi/utils.py b/src/qibocal/protocols/characterization/rabi/utils.py index ead560e27..2ed058e28 100644 --- a/src/qibocal/protocols/characterization/rabi/utils.py +++ b/src/qibocal/protocols/characterization/rabi/utils.py @@ -213,4 +213,4 @@ def period_correction_factor(phase: float): """ - return 1 - np.modf(phase / np.pi)[0] + return np.round(1 + phase / np.pi) - phase / np.pi From 2e48250aa4ef429aab8133d586f428c981e21830 Mon Sep 17 00:00:00 2001 From: Andrea Pasquale Date: Thu, 21 Dec 2023 09:38:27 +0100 Subject: [PATCH 2/2] refactor: simplify the code by using x Co-authored-by: Alessandro Candido --- src/qibocal/protocols/characterization/rabi/utils.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qibocal/protocols/characterization/rabi/utils.py b/src/qibocal/protocols/characterization/rabi/utils.py index 2ed058e28..433d6eb73 100644 --- a/src/qibocal/protocols/characterization/rabi/utils.py +++ b/src/qibocal/protocols/characterization/rabi/utils.py @@ -213,4 +213,5 @@ def period_correction_factor(phase: float): """ - return np.round(1 + phase / np.pi) - phase / np.pi + x = phase / np.pi + return np.round(1 + x) - x