Check amplitude less than 1 in _fit

[Edoardo-Pedicillo]

As the title says.

[alecandido]

Would you elaborate on the motivation or the specific routines which you have in mind?

Pulses' amplitudes are always enforced to be less than 1 in Qibolab (thus in _acquire), and I guess most fits are looking for values within the scanned range. But I may be wrong.

[Edoardo-Pedicillo]

I guess most fits are looking for values within the scanned range. But I may be wrong.

No, the fit has some bounds only on the normalized paramters, like in rabi

qibocal/src/qibocal/protocols/rabi/utils.py

Lines 348 to 373 in 5520bba

	def fit_amplitude_function(
	x, y, guess, sigma=None, signal=True, x_limits=(None, None), y_limits=(None, None)
	):
	popt, perr = curve_fit(
	rabi_amplitude_function,
	x,
	y,
	p0=guess,
	maxfev=100000,
	bounds=(
	[0, 0, 0, 0],
	[1, 1, np.inf, 2 * np.pi],
	),
	sigma=sigma,
	)
	if signal is False:
	perr = np.sqrt(np.diag(perr))
	if None not in y_limits and None not in x_limits:
	popt = [
	y_limits[0] + (y_limits[1] - y_limits[0]) * popt[0],
	(y_limits[1] - y_limits[0]) * popt[1],
	popt[2] * (x_limits[1] - x_limits[0]),
	popt[3] - 2 * np.pi * x_limits[0] / (x_limits[1] - x_limits[0]) / popt[2],
	]
	pi_pulse_parameter = popt[2] / 2 * period_correction_factor(phase=popt[3])
	return popt, perr, pi_pulse_parameter

because in 0.1 it was not necessary.