From bcb061bf1e96b7023ce6718116a5dc561bece6df Mon Sep 17 00:00:00 2001 From: Alex McCaskey Date: Fri, 18 Feb 2022 13:55:54 +0000 Subject: [PATCH 1/8] uploading first pass at runtime init / finalize workstream. Signed-off-by: Alex McCaskey --- profile/README.md | 4 + ...ime_Init_Finalize_EntryPoint_Workstream.md | 86 +++++++++++++++++++ 2 files changed, 90 insertions(+) create mode 100644 workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md diff --git a/profile/README.md b/profile/README.md index b849c08..f5cfe60 100644 --- a/profile/README.md +++ b/profile/README.md @@ -38,6 +38,10 @@ discussed: definition](https://github.com/qir-alliance/.github/blob/main/workstreams/Base_Profile_Workstream.md), [GitHub issue](https://github.com/qir-alliance/.github/issues/15)] +- Runtime initialization, finalization, and entry-Point marking and runtime parameter input
[[workstream + definition](https://github.com/qir-alliance/.github/blob/main/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md), + [GitHub issue](https://github.com/qir-alliance/.github/issues/16)] + ### Steering Committee Steering members include Microsoft, Oak Ridge National Laboratory, Quantinuum, diff --git a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md new file mode 100644 index 0000000..f4fab1d --- /dev/null +++ b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md @@ -0,0 +1,86 @@ +# Workstream: Runtime Initialization, Finalization, and Entry-Point Handling + +## Motivation & Benefits + +QIR implementation libraries provided at link time may need to rely on library +start-up and finalization routines in order to properly configure and tear-down +an underlying simulation and / or remote job submission infrastructure. Runtime +initialization also raises the question of how QIR lowering strategies should +specify entry point functions and corresponding input data provided at runtime. + +## Requirements + +The specification should define runtime initialization as a set of overloaded +functions with prescribed function name. The functions differ by argument structure, +can take the usual `(int, int8_t**)` or no arguments to indicate default initialization. + +The specification should define a finalization function declaration that takes no +arguments and is responsible for freeing all leveraged classical and quantum resources +at program exit. + +Initialization and finalization may also be required of quantum functions that are +invoked from host code. We require the declaration of function initialization and +finalization routines that QIR generators may insert at the beginning of and end +of these host-call-site quantum function calls. Note the utility of this type of function-level +functionality in the support of near-term remote job submission and flushing internal +quantum instruction queues. + +QIR generators can mark one function as `EntryPoint` via an LLVM attribute. The +function can be described with any valid function name. If the name is not `main`, +then an appropriate LLVM Pass must be applied to introduce a `__start` or `__main` +function that calls the original entry point function. + +Use cases may exist whereby QIR code is generated with a custom EntryPoint and +needs to be executed with custom command line arguments that should serve as input +to that EntryPoint function. There needs to be some specified way to map custom +command line arguments of a general type to the input arguments of the function +as well as the introduction of a `main` function for the underlying C runtime +to pick up for execution. + +## Dependencies & Related Projects + +A related workstream is to specify a base profile of the full specification. This +work should ensure that future base profile work is also compliant. + +## Deliverable(s) & Expected Outcome + +The expected outcome of this workstream is an update to the existing QIR specification +documentation that defines specific function declarations for program-level initialization +and finalization, function-level initialization and finalization for quantum functions +invoked from host call sites, and entry-point marker metadata and runtime parameter +input. + +## Future Work (Out of Scope) + +This work will not define specific initialization or finalization tasks that +a QIR implementation library should perform. This may be required in the future +but we will not handle it with this workstream. + +## Working Group & Getting Involved + +Working group participants:
+Working group chair: + +If you would like to contribute to the workstream, please contact +[qiralliance@mail.com](mailto:qiralliance@mail.com). + +## Schedule + +Launch date:
+Estimated end date:
+Meeting schedule and/or channel(s) of communication: + +## Status & Discussions + +Current status: Workstream to be approved by steering committee + +The work and status will be tracked in the form of a [GitHub +issue](https://github.com/qir-alliance/qir-spec/issues) on the [specification +repository](https://github.com/qir-alliance/qir-spec). We encourage comments, +inputs, and discussions on that issue. + +The GitHub issue with be tagged appropriately after approval by the steering +committee. + +## Open Questions + From b8b1d76baa59d571b01956e68164dc7865f2b41d Mon Sep 17 00:00:00 2001 From: Alex McCaskey Date: Wed, 23 Feb 2022 13:21:26 +0000 Subject: [PATCH 2/8] Update runtime init workstream with comments from steering committee meeting. Signed-off-by: Alex McCaskey --- ...ime_Init_Finalize_EntryPoint_Workstream.md | 54 +++++++++++-------- 1 file changed, 33 insertions(+), 21 deletions(-) diff --git a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md index f4fab1d..03c308d 100644 --- a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md +++ b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md @@ -4,43 +4,56 @@ QIR implementation libraries provided at link time may need to rely on library start-up and finalization routines in order to properly configure and tear-down -an underlying simulation and / or remote job submission infrastructure. Runtime -initialization also raises the question of how QIR lowering strategies should -specify entry point functions and corresponding input data provided at runtime. +an underlying simulation and / or remote job submission infrastructure. QIR for native +code-generation or as an exchange format with control systems may also require some +notion of start-up, initialization, and tear-down. + +Runtime initialization raises the question of how QIR lowering strategies should +specify entry point functions and corresponding input data provided at runtime. For runtime +library linking, the notion of input `argc` and `argv` can be a valuable asset to +designing dynamic and flexible QIR runtimes. For QIR as a format for backend submission, the +specification needs to carefully define what an entrypoint function is and how packaged +runtime arguments (command line or otherwise) can be injected into the entrypoint at +executable start-up. ## Requirements The specification should define runtime initialization as a set of overloaded -functions with prescribed function name. The functions differ by argument structure, -can take the usual `(int, int8_t**)` or no arguments to indicate default initialization. +functions with a prescribed function name. The functions differ by argument structure, +can take the usual `(int, int8_t**)`, no arguments to indicate default initialization, or +any other pertinent structure this proposed workstream decides on. The specification should define a finalization function declaration that takes no arguments and is responsible for freeing all leveraged classical and quantum resources at program exit. -Initialization and finalization may also be required of quantum functions that are -invoked from host code. We require the declaration of function initialization and -finalization routines that QIR generators may insert at the beginning of and end -of these host-call-site quantum function calls. Note the utility of this type of function-level +For the case of runtime library linking, initialization and finalization may also +be required of quantum functions that are invoked from host code. Library implementors may +require the declaration of fine-grained function initialization and finalization routines +that QIR generators may insert at the beginning of and end of these quantum function +calls invoked from host call-sites. The utility of this type of function-level functionality in the support of near-term remote job submission and flushing internal -quantum instruction queues. +quantum instruction queues, as well as general callbacks for library runtime event systems. -QIR generators can mark one function as `EntryPoint` via an LLVM attribute. The -function can be described with any valid function name. If the name is not `main`, -then an appropriate LLVM Pass must be applied to introduce a `__start` or `__main` -function that calls the original entry point function. +This workstream will define how QIR generators should mark a function as EntryPoint. +QIR generators can mark exactly one function as `EntryPoint` via an LLVM attribute. The +function can be described with any valid function name. If there aren't any functions +marked as `EntryPoint` then a `main` function must be present to enable execution. +For custom `EntryPoint` functions an appropriate LLVM Pass must be applied to +introduce a `__start` or `__main` function that calls the original entry point function. Use cases may exist whereby QIR code is generated with a custom EntryPoint and needs to be executed with custom command line arguments that should serve as input -to that EntryPoint function. There needs to be some specified way to map custom -command line arguments of a general type to the input arguments of the function +to that EntryPoint function. The specification needs to define some specified way to map custom +command line arguments of a general type to the input arguments of the function, as well as the introduction of a `main` function for the underlying C runtime to pick up for execution. ## Dependencies & Related Projects A related workstream is to specify a base profile of the full specification. This -work should ensure that future base profile work is also compliant. +work should ensure that future base profile work is also compliant with entrypoint +definitions and runtime input, finalization, and parameterization. ## Deliverable(s) & Expected Outcome @@ -53,13 +66,12 @@ input. ## Future Work (Out of Scope) This work will not define specific initialization or finalization tasks that -a QIR implementation library should perform. This may be required in the future -but we will not handle it with this workstream. +a QIR implementation library should perform. ## Working Group & Getting Involved -Working group participants:
-Working group chair: +Working group participants: TBD
+Working group chair: Alex McCaskey If you would like to contribute to the workstream, please contact [qiralliance@mail.com](mailto:qiralliance@mail.com). From c38327e6beecd7760a1c327d504948328ec98463 Mon Sep 17 00:00:00 2001 From: Alex McCaskey Date: Wed, 23 Feb 2022 14:19:25 +0000 Subject: [PATCH 3/8] cleanup the markdownlint-cli warnings Signed-off-by: Alex McCaskey --- ...ime_Init_Finalize_EntryPoint_Workstream.md | 111 +++++++++--------- 1 file changed, 58 insertions(+), 53 deletions(-) diff --git a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md index 03c308d..8d326f8 100644 --- a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md +++ b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md @@ -2,71 +2,76 @@ ## Motivation & Benefits -QIR implementation libraries provided at link time may need to rely on library -start-up and finalization routines in order to properly configure and tear-down -an underlying simulation and / or remote job submission infrastructure. QIR for native -code-generation or as an exchange format with control systems may also require some -notion of start-up, initialization, and tear-down. - -Runtime initialization raises the question of how QIR lowering strategies should -specify entry point functions and corresponding input data provided at runtime. For runtime -library linking, the notion of input `argc` and `argv` can be a valuable asset to -designing dynamic and flexible QIR runtimes. For QIR as a format for backend submission, the -specification needs to carefully define what an entrypoint function is and how packaged -runtime arguments (command line or otherwise) can be injected into the entrypoint at -executable start-up. +QIR implementation libraries provided at link time may need to rely on library +start-up and finalization routines in order to properly configure and tear-down +an underlying simulation and / or remote job submission infrastructure. QIR for +native code-generation or as an exchange format with control systems may also +require some notion of start-up, initialization, and tear-down. + +Runtime initialization raises the question of how QIR lowering strategies +should specify entry point functions and corresponding input data provided +at runtime. For runtime library linking, the notion of input `argc` and +`argv` can be a valuable asset to designing dynamic and flexible QIR +runtimes. For QIR as a format for backend submission, the specification +needs to carefully define what an entrypoint function is and how packaged +runtime arguments (command line or otherwise) can be injected into the +entrypoint at executable start-up. ## Requirements -The specification should define runtime initialization as a set of overloaded -functions with a prescribed function name. The functions differ by argument structure, -can take the usual `(int, int8_t**)`, no arguments to indicate default initialization, or -any other pertinent structure this proposed workstream decides on. - -The specification should define a finalization function declaration that takes no -arguments and is responsible for freeing all leveraged classical and quantum resources -at program exit. - -For the case of runtime library linking, initialization and finalization may also -be required of quantum functions that are invoked from host code. Library implementors may -require the declaration of fine-grained function initialization and finalization routines -that QIR generators may insert at the beginning of and end of these quantum function -calls invoked from host call-sites. The utility of this type of function-level -functionality in the support of near-term remote job submission and flushing internal -quantum instruction queues, as well as general callbacks for library runtime event systems. - -This workstream will define how QIR generators should mark a function as EntryPoint. -QIR generators can mark exactly one function as `EntryPoint` via an LLVM attribute. The -function can be described with any valid function name. If there aren't any functions -marked as `EntryPoint` then a `main` function must be present to enable execution. -For custom `EntryPoint` functions an appropriate LLVM Pass must be applied to -introduce a `__start` or `__main` function that calls the original entry point function. - -Use cases may exist whereby QIR code is generated with a custom EntryPoint and -needs to be executed with custom command line arguments that should serve as input -to that EntryPoint function. The specification needs to define some specified way to map custom -command line arguments of a general type to the input arguments of the function, -as well as the introduction of a `main` function for the underlying C runtime -to pick up for execution. +The specification should define runtime initialization as a set of overloaded +functions with a prescribed function name. The functions differ by argument +structure, can take the usual `(int, int8_t**)`, no arguments to indicate +default initialization, or any other pertinent structure this proposed +workstream decides on. + +The specification should define a finalization function declaration that +takes no arguments and is responsible for freeing all leveraged classical +and quantum resources at program exit. + +For the case of runtime library linking, initialization and finalization may +also be required of quantum functions that are invoked from host code. Library +implementors may require the declaration of fine-grained function +initialization and finalization routines that QIR generators may insert at +the beginning of and end of these quantum function calls invoked from host +call-sites. The utility of this type of function-level functionality in the +support of near-term remote job submission and flushing internal quantum +instruction queues, as well as general callbacks for library runtime +event systems. + +This workstream will define how QIR generators should mark a function as +EntryPoint. QIR generators can mark exactly one function as `EntryPoint` +via an LLVM attribute. The function can be described with any valid function +name. If there aren't any functions marked as `EntryPoint` then a `main` +function must be present to enable execution. For custom `EntryPoint` +functions an appropriate LLVM Pass must be applied to introduce a `__start` +or `__main` function that calls the original entry point function. + +Use cases may exist whereby QIR code is generated with a custom EntryPoint and +needs to be executed with custom command line arguments that should serve as +input to that EntryPoint function. The specification needs to define some +specified way to map custom command line arguments of a general type to the +input arguments of the function, as well as the introduction of a `main` +function for the underlying C runtime to pick up for execution. ## Dependencies & Related Projects -A related workstream is to specify a base profile of the full specification. This -work should ensure that future base profile work is also compliant with entrypoint -definitions and runtime input, finalization, and parameterization. +A related workstream is to specify a base profile of the full specification. +This work should ensure that future base profile work is also compliant with +entrypoint definitions and runtime input, finalization, and parameterization. ## Deliverable(s) & Expected Outcome -The expected outcome of this workstream is an update to the existing QIR specification -documentation that defines specific function declarations for program-level initialization -and finalization, function-level initialization and finalization for quantum functions -invoked from host call sites, and entry-point marker metadata and runtime parameter -input. +The expected outcome of this workstream is an update to the existing QIR +specification documentation that defines specific function declarations +for program-level initialization and finalization, function-level +initialization and finalization for quantum functions invoked from host +call sites, and entry-point marker metadata and runtime parameter input. ## Future Work (Out of Scope) -This work will not define specific initialization or finalization tasks that -a QIR implementation library should perform. +This work will not define specific initialization or finalization tasks +that a QIR implementation library should perform. ## Working Group & Getting Involved From 5c236cc12205ccb6ee5ae2ec3127fc45bdb0758d Mon Sep 17 00:00:00 2001 From: Alex McCaskey Date: Wed, 23 Feb 2022 14:25:11 +0000 Subject: [PATCH 4/8] Fix lint warnings on profile/README.md and update workstream definition link to point at fork for now. Signed-off-by: Alex McCaskey --- profile/README.md | 5 +++-- workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md | 7 +++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/profile/README.md b/profile/README.md index f5cfe60..73ff241 100644 --- a/profile/README.md +++ b/profile/README.md @@ -38,8 +38,9 @@ discussed: definition](https://github.com/qir-alliance/.github/blob/main/workstreams/Base_Profile_Workstream.md), [GitHub issue](https://github.com/qir-alliance/.github/issues/15)] -- Runtime initialization, finalization, and entry-Point marking and runtime parameter input
[[workstream - definition](https://github.com/qir-alliance/.github/blob/main/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md), +- Runtime initialization, finalization, and entry-Point marking and runtime + parameter input
[[workstream + definition](https://github.com/amccaskey/.github/blob/main/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md), [GitHub issue](https://github.com/qir-alliance/.github/issues/16)] ### Steering Committee diff --git a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md index 8d326f8..f7318b3 100644 --- a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md +++ b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md @@ -36,7 +36,7 @@ initialization and finalization routines that QIR generators may insert at the beginning of and end of these quantum function calls invoked from host call-sites. The utility of this type of function-level functionality in the support of near-term remote job submission and flushing internal quantum -instruction queues, as well as general callbacks for library runtime +instruction queues, as well as general callbacks for library runtime event systems. This workstream will define how QIR generators should mark a function as @@ -52,7 +52,7 @@ needs to be executed with custom command line arguments that should serve as input to that EntryPoint function. The specification needs to define some specified way to map custom command line arguments of a general type to the input arguments of the function, as well as the introduction of a `main` -function for the underlying C runtime to pick up for execution. +function for the underlying C runtime to pick up for execution. ## Dependencies & Related Projects @@ -99,5 +99,4 @@ inputs, and discussions on that issue. The GitHub issue with be tagged appropriately after approval by the steering committee. -## Open Questions - +## Open Questions \ No newline at end of file From 02832c7f0dc26505486e1c50d2457b772eb5c978 Mon Sep 17 00:00:00 2001 From: Alex McCaskey Date: Wed, 23 Feb 2022 14:36:07 +0000 Subject: [PATCH 5/8] Adding single trailing new line Signed-off-by: Alex McCaskey --- workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md index f7318b3..b43cd2c 100644 --- a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md +++ b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md @@ -99,4 +99,4 @@ inputs, and discussions on that issue. The GitHub issue with be tagged appropriately after approval by the steering committee. -## Open Questions \ No newline at end of file +## Open Questions From 6c6195e8a1e87dde4b4a06df09e592effaa53c0a Mon Sep 17 00:00:00 2001 From: Alex McCaskey Date: Fri, 18 Mar 2022 15:37:59 +0000 Subject: [PATCH 6/8] Update runtime init workstream with latest feedback from March 18, 2022 SC meeting. Signed-off-by: Alex McCaskey --- profile/README.md | 2 +- ...ime_Init_Finalize_EntryPoint_Workstream.md | 24 +++++++++++++++---- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/profile/README.md b/profile/README.md index 73ff241..b54decf 100644 --- a/profile/README.md +++ b/profile/README.md @@ -40,7 +40,7 @@ discussed: - Runtime initialization, finalization, and entry-Point marking and runtime parameter input
[[workstream - definition](https://github.com/amccaskey/.github/blob/main/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md), + definition](https://github.com/qir-alliance/.github/blob/main/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md), [GitHub issue](https://github.com/qir-alliance/.github/issues/16)] ### Steering Committee diff --git a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md index b43cd2c..6adb6ab 100644 --- a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md +++ b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md @@ -40,12 +40,24 @@ instruction queues, as well as general callbacks for library runtime event systems. This workstream will define how QIR generators should mark a function as -EntryPoint. QIR generators can mark exactly one function as `EntryPoint` +EntryPoint. QIR generators can mark **exactly one** function as `EntryPoint` via an LLVM attribute. The function can be described with any valid function name. If there aren't any functions marked as `EntryPoint` then a `main` function must be present to enable execution. For custom `EntryPoint` -functions an appropriate LLVM Pass must be applied to introduce a `__start` -or `__main` function that calls the original entry point function. +functions, an appropriate LLVM Pass must be applied to introduce a `__start` +or `__main` function that calls the original entry point function. The +workstream should also take into account the validity of return types +for a custom `EntryPoint`. Likely, the return type should model some return +status code (e.g. with an integer). This should be discussed in the +workstream. The return of quantum execution results should be left as a +topic for future workstreams. + +The utility of QIR code that lacks an `EntryPoint` function or `main` lies +in its lowering to object code and archival into static or shared libraries. +QIR can omit `main` or `EntryPoint` and can thereby enable a modular approach +for the construction of quantum-classical applications. We leave this concept +(modular QIR) for future workstreams, but the work done here should directly +enable these modular capabilities. Use cases may exist whereby QIR code is generated with a custom EntryPoint and needs to be executed with custom command line arguments that should serve as @@ -71,7 +83,8 @@ call sites, and entry-point marker metadata and runtime parameter input. ## Future Work (Out of Scope) This work will not define specific initialization or finalization tasks -that a QIR implementation library should perform. +that a QIR implementation library should perform. This work will not study +the return of quantum execution results by `EntryPoint` functions. ## Working Group & Getting Involved @@ -79,7 +92,8 @@ Working group participants: TBD
Working group chair: Alex McCaskey If you would like to contribute to the workstream, please contact -[qiralliance@mail.com](mailto:qiralliance@mail.com). +[qiralliance@mail.com](mailto:qiralliance@mail.com) and / or +[Alex McCaskey](mailto:amccaskey@nvidia.com). ## Schedule From bf755d6c2a6b1f94b3544a3bbeda972da1a2fd8d Mon Sep 17 00:00:00 2001 From: Alex McCaskey Date: Fri, 18 Mar 2022 15:42:33 +0000 Subject: [PATCH 7/8] fix dead link and trailing space warnings Signed-off-by: Alex McCaskey --- profile/README.md | 2 +- workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/profile/README.md b/profile/README.md index b54decf..1065145 100644 --- a/profile/README.md +++ b/profile/README.md @@ -40,7 +40,7 @@ discussed: - Runtime initialization, finalization, and entry-Point marking and runtime parameter input
[[workstream - definition](https://github.com/qir-alliance/.github/blob/main/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md), + definition](../workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md), [GitHub issue](https://github.com/qir-alliance/.github/issues/16)] ### Steering Committee diff --git a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md index 6adb6ab..9dfc067 100644 --- a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md +++ b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md @@ -84,7 +84,7 @@ call sites, and entry-point marker metadata and runtime parameter input. This work will not define specific initialization or finalization tasks that a QIR implementation library should perform. This work will not study -the return of quantum execution results by `EntryPoint` functions. +the return of quantum execution results by `EntryPoint` functions. ## Working Group & Getting Involved From fe5f1b9f9b5ec052f2430a4b162bee3150298a0d Mon Sep 17 00:00:00 2001 From: Alex McCaskey Date: Thu, 21 Apr 2022 12:39:12 +0000 Subject: [PATCH 8/8] addressing final cleanup comments for SC approval Signed-off-by: Alex McCaskey --- profile/README.md | 5 ----- .../Runtime_Init_Finalize_EntryPoint_Workstream.md | 12 +++++------- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/profile/README.md b/profile/README.md index 60ade4a..3990bbc 100644 --- a/profile/README.md +++ b/profile/README.md @@ -48,11 +48,6 @@ discussed: ![QIR Alliance](https://github.com/qir-alliance/.github/blob/main/.images/header2.png) - -- Runtime initialization, finalization, and entry-Point marking and runtime - parameter input
[[workstream - definition](../workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md), - [GitHub issue](https://github.com/qir-alliance/.github/issues/16)] ### Steering Committee diff --git a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md index 9dfc067..5e0ac90 100644 --- a/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md +++ b/workstreams/Runtime_Init_Finalize_EntryPoint_Workstream.md @@ -69,8 +69,9 @@ function for the underlying C runtime to pick up for execution. ## Dependencies & Related Projects A related workstream is to specify a base profile of the full specification. -This work should ensure that future base profile work is also compliant with -entrypoint definitions and runtime input, finalization, and parameterization. +Once defined, this specification will guide future iterations of the base +profile, which must remain compliant in entrypoint definitions, runtime input, +finalization, and parameterization. ## Deliverable(s) & Expected Outcome @@ -103,14 +104,11 @@ Meeting schedule and/or channel(s) of communication: ## Status & Discussions -Current status: Workstream to be approved by steering committee +Current status: Workstream has been approved. The work and status will be tracked in the form of a [GitHub -issue](https://github.com/qir-alliance/qir-spec/issues) on the [specification +issue](https://github.com/qir-alliance/qir-spec/issues/11) on the [specification repository](https://github.com/qir-alliance/qir-spec). We encourage comments, inputs, and discussions on that issue. -The GitHub issue with be tagged appropriately after approval by the steering -committee. - ## Open Questions