Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Keyboard profile change wipes keymap, wrong initial load #1019

Open
Invertisment opened this issue Nov 19, 2021 · 2 comments
Open

[Bug] Keyboard profile change wipes keymap, wrong initial load #1019

Invertisment opened this issue Nov 19, 2021 · 2 comments
Labels

Comments

@Invertisment
Copy link

Invertisment commented Nov 19, 2021

Describe the Bug

I'm still trying out the web UI and I think there is a bug.
When I choose a keyboard (let's say k320 or eagle_viper) it may have multiple layouts.
And initially it loads fine (but if I'll use k320tkl then it's a wrong layout). And if I change the layout in the dropdown menu then all keys disappear. Is this supposed to happen?

It happens for two keyboards so I think it should happen to all of them.

Reproduction:

  1. Open https://config.qmk.fm/#/duck/eagle_viper/v2/LAYOUT_all or https://config.qmk.fm/#/durgod/k3x0/k320/base/LAYOUT_all
  2. Choose a different layout
  3. Keymap values disappear

Also a bad layout is applied when navigating to a page where the keyboard layout is already picked.
Try opening this in a new tab: https://config.qmk.fm/#/durgod/k3x0/k320/base/LAYOUT_tkl_ansi

The default layout for this keyboard is all but if I open tkl one then most of the keys are mapped to wrong values.

Additional Context?

No response

@Invertisment Invertisment changed the title [Bug] Should keyboard profile change result in filled profile? [Bug] Keyboard profile change wipes keymap Nov 19, 2021
@Invertisment Invertisment changed the title [Bug] Keyboard profile change wipes keymap [Bug] Keyboard profile change wipes keymap, wrong initial load Nov 19, 2021
@noroadsleft
Copy link
Member

And initially it loads fine (but if I'll use k320tkl then it's a wrong layout). And if I change the layout in the dropdown menu then all keys disappear. Is this supposed to happen?

This is the expected behaviour. QMK Configurator only supports one default keymap per keyboard at this time. Changing the layout doesn't prompt Configurator to look for an appropriate default keymap.

Also a bad layout is applied when navigating to a page where the keyboard layout is already picked.
Try opening this in a new tab: config.qmk.fm/#/durgod/k3x0/k320/base/LAYOUT_tkl_ansi

This is a long-standing regression of sorts. QMK Configurator used to stay on the layout specified in the URL if you clicked a link that specified both a keyboard and a layout (without searching for a default keymap), but now it loads the default keymap all the time. I don't recall if this is by design, but it's been this way for a few years.

@Invertisment
Copy link
Author

I'm not sure how it's useful. Instead I expected a pre-filled tkl keymap. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants