Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker SCSS variables #121

Open
jt-adwisemedia opened this issue Oct 1, 2021 · 0 comments
Open

Datepicker SCSS variables #121

jt-adwisemedia opened this issue Oct 1, 2021 · 0 comments

Comments

@jt-adwisemedia
Copy link

jt-adwisemedia commented Oct 1, 2021

Hello!

This is more of a suggestion, having issues overriding your ./src/datepicker.scss.

  1. You should really put your variables in a ./src/variables.scss file and make sure that all variables have the !default "tag" after each variable.
  2. You should also make sure that all colors use variables instead of hardcoding "orange".

And yeah I can do do manual overrides and use !important, however...

  1. Using !important is generally a bad practise.
  2. It would result in double the amount of CSS, possibly even more if someone would need to use a more specific rule, and what I mean is that I would first have to include ./src/datepicker.scss and then I would have to also have to add add my own overwrites for the same rules that already exists in ./src/datepicker.scss, resulting in double or more CSS in the final dist file, also a bad practise.

Best regards,
JT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant