You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is more of a suggestion, having issues overriding your ./src/datepicker.scss.
You should really put your variables in a ./src/variables.scss file and make sure that all variables have the !default "tag" after each variable.
You should also make sure that all colors use variables instead of hardcoding "orange".
And yeah I can do do manual overrides and use !important, however...
Using !important is generally a bad practise.
It would result in double the amount of CSS, possibly even more if someone would need to use a more specific rule, and what I mean is that I would first have to include ./src/datepicker.scss and then I would have to also have to add add my own overwrites for the same rules that already exists in ./src/datepicker.scss, resulting in double or more CSS in the final dist file, also a bad practise.
Best regards,
JT
The text was updated successfully, but these errors were encountered:
Hello!
This is more of a suggestion, having issues overriding your
./src/datepicker.scss
../src/variables.scss
file and make sure that all variables have the!default
"tag" after each variable.And yeah I can do do manual overrides and use
!important
, however...!important
is generally a bad practise../src/datepicker.scss
and then I would have to also have to add add my own overwrites for the same rules that already exists in./src/datepicker.scss
, resulting in double or more CSS in the final dist file, also a bad practise.Best regards,
JT
The text was updated successfully, but these errors were encountered: