Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI does not test julia 1.3 (which is in compat) | QOB.jl tests fail on julia 1.3 #139

Closed
Krastanov opened this issue Sep 13, 2023 · 4 comments

Comments

@Krastanov
Copy link
Collaborator

I noticed this when reviewing #133 so I decided to install julia 1.3 and run the tests. They fail.

@david-pl , @ChristophHotter , @amilsted , should we try to fix the tests or should we bump the julia compat to 1.6? I personally lean towards bumping the compat given our limited manpower.

@Krastanov
Copy link
Collaborator Author

actually, it is a bit worse:

  • current master has dependencies that can not install on julia 1.3 as you can see in the CI of add julia 1.3 to CI #140
  • the latest version that can install on julia 1.3 is 0.3.7 and its tests fail.

The exact errors is:

/test/test_operators_lazytensor.jl:381
  Test threw exception
  Expression: all(map(isconcretetype, T.parameters))
  type UnionAll has no field parameters

Because of this, I think it is best to bump the compat bound to julia 1.6... But we have test failures on 1.6 too (see #141)

@Krastanov
Copy link
Collaborator Author

I fixed the julia 1.6 issue in #141

@ChristophHotter
Copy link
Member

Bumping the julia compat to 1.6 is fine for me.

@Krastanov
Copy link
Collaborator Author

David merged the 1.6 bump so I am closing this issue as fixed by #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants