Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve piracies and ambiguities #173

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Solve piracies and ambiguities #173

merged 3 commits into from
Aug 5, 2024

Conversation

Tortar
Copy link
Contributor

@Tortar Tortar commented Aug 3, 2024

@Krastanov
Copy link
Collaborator

Thanks! This looks good, I will merge shortly if tests pass!

FYI for other maintainers: this is part of a bunch of PRs that are removing type piracies from package that depend on QuantumInterface (basically upstreaming these changes from QuantumSavory)

@Tortar
Copy link
Contributor Author

Tortar commented Aug 4, 2024

This should be okay now

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.04%. Comparing base (bb71f52) to head (eaed309).
Report is 12 commits behind head on master.

Files Patch % Lines
src/operators_dense.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   93.00%   93.04%   +0.03%     
==========================================
  Files          25       26       +1     
  Lines        3104     3206     +102     
==========================================
+ Hits         2887     2983      +96     
- Misses        217      223       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krastanov Krastanov merged commit 06c2845 into qojulia:master Aug 5, 2024
10 checks passed
@Krastanov
Copy link
Collaborator

Thank you! This is merged and being released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants