From 3c2aca2995a51006df5530261846d957a30bb51e Mon Sep 17 00:00:00 2001 From: Vincent Mercier Date: Tue, 16 Apr 2024 15:51:20 +0200 Subject: [PATCH] fix --- .github/workflows/test.yaml | 40 +++++++++---------- .../infra/postgresql/column_internal_test.go | 2 +- internal/infra/uuid7/uuid7.go | 3 +- 3 files changed, 23 insertions(+), 22 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 8544a9d..b3bad9c 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -27,26 +27,26 @@ jobs: run: make build - name: Run Go tests run: make test - # - name: Code Coverage Report - # uses: irongut/CodeCoverageSummary@v1.3.0 - # with: - # filename: coverage.xml - # badge: true - # fail_below_min: true - # format: markdown - # hide_branch_rate: false - # hide_complexity: true - # indicators: true - # output: both - # thresholds: '60 80' - # - uses: jwalton/gh-find-current-pr@v1 - # id: finder - # - name: Add Coverage PR Comment - # uses: marocchino/sticky-pull-request-comment@v2 - # with: - # number: ${{ steps.finder.outputs.pr }} - # path: code-coverage-results.md - # recreate: true + - name: Code Coverage Report + uses: irongut/CodeCoverageSummary@v1.3.0 + with: + filename: coverage.xml + badge: true + fail_below_min: true + format: markdown + hide_branch_rate: false + hide_complexity: true + indicators: true + output: both + thresholds: '60 80' + - uses: jwalton/gh-find-current-pr@v1 + id: finder + - name: Add Coverage PR Comment + uses: marocchino/sticky-pull-request-comment@v2 + with: + number: ${{ steps.finder.outputs.pr }} + path: code-coverage-results.md + recreate: true - name: Upload artifact uses: actions/upload-artifact@v4 diff --git a/internal/infra/postgresql/column_internal_test.go b/internal/infra/postgresql/column_internal_test.go index 9801a72..73dc97a 100644 --- a/internal/infra/postgresql/column_internal_test.go +++ b/internal/infra/postgresql/column_internal_test.go @@ -16,7 +16,7 @@ func TestGetColumn(t *testing.T) { Name: "my_column", } - query := `SELECT data_type as columnType FROM information_schema.columns WHERE table_schema = \$1 AND table_name = \$2 AND column_name = \$3` + const query = `SELECT data_type as columnType FROM information_schema.columns WHERE table_schema = \$1 AND table_name = \$2 AND column_name = \$3` mock, err := pgxmock.NewConn() if err != nil { diff --git a/internal/infra/uuid7/uuid7.go b/internal/infra/uuid7/uuid7.go index 533790a..1ecbf35 100644 --- a/internal/infra/uuid7/uuid7.go +++ b/internal/infra/uuid7/uuid7.go @@ -8,6 +8,7 @@ import ( "time" ) +//nolint:gomnd func FromTime(timestamp time.Time) string { // Convert timestamp to Unix time in milliseconds unixMillis := timestamp.UnixNano() / int64(time.Millisecond) @@ -28,7 +29,7 @@ func FromTime(timestamp time.Time) string { } // Combine time bytes and random bytes - uuidBytes := append(timeBytes, randomBytes...) + uuidBytes := append(timeBytes, randomBytes...) //nolint:gocritic,makezero // Set the version byte (7 for UUIDv7, as a placeholder since we're doing a UUIDv7-like) // Corrected to use the appropriate index after ensuring uuidBytes is 16 bytes