Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect result when ORDER BY used with LIMIT or OFFSET #10

Open
ikopylov opened this issue Feb 1, 2017 · 0 comments
Open

Incorrect result when ORDER BY used with LIMIT or OFFSET #10

ikopylov opened this issue Feb 1, 2017 · 0 comments
Labels
bug

Comments

@ikopylov
Copy link
Member

ikopylov commented Feb 1, 2017

Currently script parser removes ORDER BY clause from script which leads to applying LIMIT and OFFSET to non-ordered sequence:
https://github.com/qoollo/bricksdb/blob/develop/src/StorageSystem.Impl.Sql/Internal/SqlScriptParser.cs#L262
https://github.com/qoollo/bricksdb/blob/develop/src/BriksDb.Impl.Postgre/Internal/PostgreScriptParser.cs#L146
It is much better not to touch the user script in any way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ikopylov