Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks against your own code #105

Open
theofidry opened this issue Feb 10, 2016 · 1 comment
Open

Checks against your own code #105

theofidry opened this issue Feb 10, 2016 · 1 comment

Comments

@theofidry
Copy link
Contributor

If I understand right right now running check script ruleset, it check any usage of deprecated call inside script based on the @deprecated annotations defined by the ruleset (usually vendor or composer.lock).

However you might want to use this tool four handling migration in your own app, ex:

/**
 * @deprecated Use NewModel instead
 */
class LegacyModel {...}

class NewModel {...}

This is doable by running deprecation-detector src src for example, but I find it weird. Plus that means in this use case, you actually have to run two times the command:

$ deprecation-detector src composer.lock
$ deprecation-detector src src

It would make more sense IMO to include src (or rather the directory being checked) to the ruleset by default.

@MarvinKlemp
Copy link
Contributor

Good catch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants