Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect list index and object name used in crossval() and summarize_results(). #32

Open
Mayazure opened this issue Oct 13, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Mayazure
Copy link
Contributor

In crossval.R:

In line 41 and 42: the k (number of folds) should be i (index of current fold).

In line 69 and 70: object x should be x_df.

The second typo resulted in wrong values for precision, recall and f1 when aggregate over folds and classes, so that:

  1. F1 value may be greater than both Precision and Recall
  2. Average recall and balanced accuracy will have unequal value (which should be identical).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants