Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headline "Test for object identity should be is" doesn't match content #131

Open
hjp opened this issue Jul 28, 2019 · 0 comments
Open

Headline "Test for object identity should be is" doesn't match content #131

hjp opened this issue Jul 28, 2019 · 0 comments

Comments

@hjp
Copy link

hjp commented Jul 28, 2019

Apart from being phrased the wrong way (the headline names the pattern, not the anti-pattern), it doesn't match the content.

The anti-pattern is about using is for equality tests, not about using something besides is for identity tests.

The headline should be changed to "Using is for equality testing" or something like that.

(There should probably also be an anti-pattern "Using == for identity testing" - I see stuff like x == None or (worse) x == True far more often than a misguided is)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant