Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up test_create_job in cirq-google/cirq_google/engine/engine_client_test.py #6761

Open
senecameeks opened this issue Oct 10, 2024 · 0 comments
Open

Clean up test_create_job in cirq-google/cirq_google/engine/engine_client_test.py #6761

senecameeks opened this issue Oct 10, 2024 · 0 comments
Labels
kind/health For CI/testing/release process/refactoring/technical debt items
Milestone
2025-T6: Code hea...

Comments

@senecameeks
Copy link
Collaborator

Test_create_job tests successful job creation as well as when a job creation throws an error. Separate these assertions into separate tests and make their names more descriptive (e.g follow python unit test naming convention style guide)
@senecameeks senecameeks added the kind/health For CI/testing/release process/refactoring/technical debt items label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/health For CI/testing/release process/refactoring/technical debt items
Projects
Cirq 2025 roadmap
Status: No status
Milestone
2025-T6: Code health and project main...
Development

No branches or pull requests
2 participants
@mhucka @senecameeks