-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Convert more type annotations to latest Python built-in #7339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Per PEP-585 we should use We can also replace cc @codrut3 |
Is anyone working on this? And is there already a related PR? If no one has already claimed it, I want to work on this task. |
Feel free to do this @Akshita07 Otherwise I'll have a look in a couple of days. |
Thank you @codrut3 :) |
@Akshita07 OK, I've assigned it to you. Thank you for your interest! With respect to this question: "is there already a related PR": there was not for this specific matter, but there is an ongoing series of PRs from @pavoljuhas to make some other type annotation updates. I don't think the changes will interfere with each other, but you may still want to take a look in the closed PRs for recent type annotation-related PRs by Pavol, and just look at what the changes involved. |
Thanks @Akshita07 for your offer to help! I have an ongoing series of PRs to address #1999 which should be wrapped up by mid next week. It is probably better to hold on with your changes so there is no interference; that said, any files that were already touched in #7193, #7278, #7295, #7298, #7317, #7325, #7343 are safe to work on. |
Thanks @mhucka and @pavoljuhas for the information. I'll check the closed PRs and make my changes accordingly. |
Hi @Akshita07, I am done with a possibly interfering PR #7357 and @dstrain115 with #7355. Feel free to take this over to fix the remaining issues from
|
Updates following type annotations: - typing.Dict to dict - typing.List to list - typing.Tuple to tuple - typing.Set to set - typing.FrozenSet to frozenset - typing.Type to type - typing.Union to X | Y - typing.Optional to X | None Addresses issue [#7339] --------- Co-authored-by: Pavol Juhas <[email protected]>
Recent versions of Python offer updated type annotation syntaxes. Cirq should make use of them.
The text was updated successfully, but these errors were encountered: