Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative rotation compilations/costs #370

Closed
fdmalone opened this issue Sep 26, 2023 · 4 comments
Closed

Alternative rotation compilations/costs #370

fdmalone opened this issue Sep 26, 2023 · 4 comments

Comments

@fdmalone
Copy link
Collaborator

Currently our T costs derive from https://arxiv.org/pdf/1404.5320.pdf, which gives a mean cost of 1.149 log2
(1/ε) + 9.2 for a target precision of ε.

Many papers use a phase gradient gate instead for rotations (appendix A of https://doi.org/10.1103/PRXQuantum.1.020312) which requires b_r - 2 Toffolis for b_r bits of precision (it uses the first method to prepare a phase gradient register first and then adds into this). This is often significantly cheaper.

Need to think about rotations.

@mpharrigan mpharrigan changed the title Rotations Alternative rotation compilations/costs Sep 29, 2023
@mpharrigan
Copy link
Collaborator

cc @NoureldinYosri who has been thinking about this

@NoureldinYosri
Copy link
Contributor

we currenly have a unified approach to the vanilla rotation models RotationLogarithmicModel and for constant cost models ConstantWithOverheadRotationCost both of which implement the same interface of RotationCostModel

Do we need to do more for this?

@mpharrigan
Copy link
Collaborator

Related: #1250

@mpharrigan mpharrigan added this to the v1.0 milestone Aug 8, 2024
@mpharrigan
Copy link
Collaborator

Going to close this in favor of #1250 or open new issues to track specific asks

@mpharrigan mpharrigan closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants