-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial det/obs support to crumble, plus other polish #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve extra-markers drawing - Detectors and observables now position markers by ordered filling instead of by index - Default polygons to be more transparent - Make unused qubits more transparent
… timeline viewer left justified
Strilanc
changed the title
[WIP] Add UX for creating detectors in crumble
Add initial det/obs support to crumble, plus other polish
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tagalong Stim diagram improvements:
Crumble improvements:
Fix hitting 1-9 on an MPP operation not inferring that it should mark every target of the operation in their basis
Add initial support for detectors
d+#
to turn a marked flow into a detectoro+#
to turn a marked flow into an observablej+#
to pick an arbitrary det or obs with a detection region going through the current selection, and turn it into ak+#
to add markers to dissipative gates overlapping the propagating flow in the current layermarked flow
Fix feedback operations not being correctly ignored, or causing non-feedback parts of an operation to be discarded
Polish the scrubber
Polish the visuals
P
and#
doAdd quality of life controls
F
to flip two qubit gates (e.g. exchange target and control)C_XYZ
gate fromF
toc+t
G
to reverse the order of layers starting from the current layer ending at first empty layer>
,<
,^
,v
to translate coordinates in the indicated direction.
to translate circuit downright one half stephome
/end
to jump to start/end of circuitshift+q/e
to jump 5 layers at a timeAdded more example circuits, and moved examples behind a "show examples" button
Fix frame gate methods targeting indices instead of targets
Add frame undo gate methods
Fixes crumble e and q don't work with capslock #771
Fixes Crumble importing classically controlled gates #715
Fixes In crumble, fix pauli highlight not crossing a terminal pair measurement #738