Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copyright checker for pylint-3 #211

Merged
merged 14 commits into from
Oct 7, 2024
Merged

Update copyright checker for pylint-3 #211

merged 14 commits into from
Oct 7, 2024

Conversation

pavoljuhas
Copy link
Contributor

@pavoljuhas pavoljuhas commented Oct 4, 2024 •
edited
Loading

The previous CI pylint check was ineffective.
Run it for real here and clean up some of the exposed lint.

  • Use the latest pylint-3 for the lint CI check
  • Copy pylint_copyright_checker from Cirq and adjust the copyright text
  • Use the same pylint configuration as in Cirq, apart from line length
  • pylint - fix singleton-comparison
  • pylint - fix docstring-first-line-empty
  • pylint - fix f-string-without-interpolation
  • pylint - fix wrong-or-nonexistent-copyright-notice
  • pylint - fix wrong-import-order
  • pylint - fix unused-import
  • Temporarily disable rules that fail in pylint-3 and mark them with TODO comments

Partially fixes #210

@pavoljuhas pavoljuhas force-pushed the update-pylint-copyright-checker branch from 8266bff to 08b0c80 Compare October 4, 2024 18:04
@pavoljuhas pavoljuhas marked this pull request as ready for review October 4, 2024 18:24
@pavoljuhas
Copy link
Contributor Author

@dstrain115 - PTAL

@dstrain115 dstrain115 self-requested a review October 7, 2024 18:46
dstrain115
dstrain115 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reenabling and cleaning all this up.

@dstrain115 dstrain115 merged commit b1d23ae into quantumlib:main Oct 7, 2024
6 checks passed
@pavoljuhas pavoljuhas deleted the update-pylint-copyright-checker branch October 7, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstrain115 dstrain115 dstrain115 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev_tools/pylint fails with pylint-3 and later
2 participants
@pavoljuhas @dstrain115