-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push the built site to a docs branch #170
Comments
I thought it wasn't even possible to deploy to pages without pushing to a branch first, but looking at the workflows, the official actions for pages do it by an upload instead. If we didn't want to fuss with the workflow here, the CI artifacts (such as https://github.com/quarkiverse/quarkiverse-docs/actions/runs/9991399209/artifacts/1714955609) could be used ... but it's probably easier to just add an extra step in the workflow than it is to fuss with getting the ID of the latest CI run and then browsing its artifacts. |
+1. Both are possible, but pushing to a branch is much easier; be it only for testing. |
-1 to pushing to a branch to deploy to GH Pages: The existing workflow was migrated from that to prevent messing around with the generated content. +1 to add an extra step in the workflow to do whatever is necessary (including pushing the generated content to search.quarkus.io if necessary) |
Fine.
Pushing to search.quarkus.io is not a good idea, as the service is currently "stateless" -- in the sense that it can be dropped and redeployed at will, and it will reinitialize itself. I wouldn't want to push state there that cannot easily be re-generated. If we can change the workflow though, maybe we could have it publish a GitHub "release" or "package". I imagine there are ways to cache these on the search.quarkus.io side -- using SHAs or IDs or whatever. |
I think there's three options.
|
I mentioned releases because I think build artifacts expire after some time... but I suppose this doesn't matter if we're sure we'll rebuild quarkiverse-docs nightly. search.quarkus.io already has the GitHub API in the classpath, and we've already set up a GitHub account for it (so that it can report about indexing at quarkusio/search.quarkus.io#130). So it could definitely figure out what to download.
Note search.quarkus.io is deployed as a simple Quarkus application, without data. Indexing happens at runtime (on startup, and every day), not at build time. So GitHub actions are not an option here. Anyway, thanks all for your suggestions. I think we have all the information we need, now we'll need to find time to work on this :) |
There's a world of automation beyond GitHub Actions and build-time? 🤯 (Er, joke, in case it wasn't obvious. 😀 ... but I actually do sort out so much of my professional life through the mechanism of GH Actions workflows it is genuinely useful to be reminded there are other ways.) |
To help move forward the indexing of Quarkiverse guides and then provide search capabilities over them (quarkusio/search.quarkus.io#260) we should push the built HTML pages to some branch in this repository.
This way search.quarkus.io will be able to fetch the repository and work with the local filesystem to scrape the data it needs rather than relying on fetching each page separately over HTTP.
The text was updated successfully, but these errors were encountered: