From b6c6e16e10f303ef79346ff83f88987f61f3b0d5 Mon Sep 17 00:00:00 2001 From: Guillaume Smet Date: Thu, 24 Aug 2023 22:37:56 +0200 Subject: [PATCH] Also register CacheLoader for reflection This actually solves the warning we have in native executables. --- .../githubapp/deployment/GitHubAppProcessor.java | 6 ++++++ docs/modules/ROOT/pages/includes/attributes.adoc | 2 +- .../ROOT/pages/includes/quarkus-github-app.adoc | 10 ++++++++++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/deployment/src/main/java/io/quarkiverse/githubapp/deployment/GitHubAppProcessor.java b/deployment/src/main/java/io/quarkiverse/githubapp/deployment/GitHubAppProcessor.java index 5413e654..f68e2159 100644 --- a/deployment/src/main/java/io/quarkiverse/githubapp/deployment/GitHubAppProcessor.java +++ b/deployment/src/main/java/io/quarkiverse/githubapp/deployment/GitHubAppProcessor.java @@ -52,6 +52,8 @@ import org.objectweb.asm.MethodVisitor; import org.objectweb.asm.Opcodes; +import com.github.benmanes.caffeine.cache.CacheLoader; + import io.quarkiverse.githubapp.ConfigFile; import io.quarkiverse.githubapp.GitHubEvent; import io.quarkiverse.githubapp.deployment.DispatchingConfiguration.EventAnnotation; @@ -193,6 +195,10 @@ void registerForReflection(CombinedIndexBuildItem combinedIndex, .methods(true) .fields(true) .build()); + reflectiveClasses.produce(ReflectiveClassBuildItem + .builder(CacheLoader.class) + .methods(true) + .build()); reflectiveClasses.produce(ReflectiveClassBuildItem .builder(GitHubService.class.getName() + "$CreateInstallationToken") .methods(true) diff --git a/docs/modules/ROOT/pages/includes/attributes.adoc b/docs/modules/ROOT/pages/includes/attributes.adoc index c08434e8..5baabf5d 100644 --- a/docs/modules/ROOT/pages/includes/attributes.adoc +++ b/docs/modules/ROOT/pages/includes/attributes.adoc @@ -1,4 +1,4 @@ -:quarkus-version: 3.2.3.Final +:quarkus-version: 3.3.0 :quarkus-github-app-version: 2.0.5 :github-api-javadoc-root-url: https://github-api.kohsuke.org/apidocs/org/kohsuke/github diff --git a/docs/modules/ROOT/pages/includes/quarkus-github-app.adoc b/docs/modules/ROOT/pages/includes/quarkus-github-app.adoc index 43db1a54..f72a3bb8 100644 --- a/docs/modules/ROOT/pages/includes/quarkus-github-app.adoc +++ b/docs/modules/ROOT/pages/includes/quarkus-github-app.adoc @@ -12,6 +12,7 @@ h|Default a| [[quarkus-github-app_quarkus.github-app.app-id]]`link:#quarkus-github-app_quarkus.github-app.app-id[quarkus.github-app.app-id]` + [.description] -- The numeric application id provided by GitHub. @@ -30,6 +31,7 @@ endif::add-copy-button-to-env-var[] a| [[quarkus-github-app_quarkus.github-app.app-name]]`link:#quarkus-github-app_quarkus.github-app.app-name[quarkus.github-app.app-name]` + [.description] -- The GitHub name of the application. @@ -48,6 +50,7 @@ endif::add-copy-button-to-env-var[] a| [[quarkus-github-app_quarkus.github-app.read-config-files-from-source-repository]]`link:#quarkus-github-app_quarkus.github-app.read-config-files-from-source-repository[quarkus.github-app.read-config-files-from-source-repository]` + [.description] -- Read the configuration files from the source repository in case of a fork. @@ -64,6 +67,7 @@ endif::add-copy-button-to-env-var[] a| [[quarkus-github-app_quarkus.github-app.private-key]]`link:#quarkus-github-app_quarkus.github-app.private-key[quarkus.github-app.private-key]` + [.description] -- The RSA private key. @@ -83,6 +87,7 @@ endif::add-copy-button-to-env-var[] a| [[quarkus-github-app_quarkus.github-app.webhook-secret]]`link:#quarkus-github-app_quarkus.github-app.webhook-secret[quarkus.github-app.webhook-secret]` + [.description] -- The webhook secret if defined in the GitHub UI. @@ -99,6 +104,7 @@ endif::add-copy-button-to-env-var[] a| [[quarkus-github-app_quarkus.github-app.webhook-proxy-url]]`link:#quarkus-github-app_quarkus.github-app.webhook-proxy-url[quarkus.github-app.webhook-proxy-url]` + [.description] -- The Smee.io proxy URL used when testing locally. @@ -115,6 +121,7 @@ endif::add-copy-button-to-env-var[] a| [[quarkus-github-app_quarkus.github-app.instance-endpoint]]`link:#quarkus-github-app_quarkus.github-app.instance-endpoint[quarkus.github-app.instance-endpoint]` + [.description] -- The GitHub instance endpoint. @@ -133,6 +140,7 @@ endif::add-copy-button-to-env-var[] a| [[quarkus-github-app_quarkus.github-app.rest-api-endpoint]]`link:#quarkus-github-app_quarkus.github-app.rest-api-endpoint[quarkus.github-app.rest-api-endpoint]` + [.description] -- The REST API endpoint. @@ -151,6 +159,7 @@ endif::add-copy-button-to-env-var[] a| [[quarkus-github-app_quarkus.github-app.graphql-api-endpoint]]`link:#quarkus-github-app_quarkus.github-app.graphql-api-endpoint[quarkus.github-app.graphql-api-endpoint]` + [.description] -- The GraphQL API endpoint. @@ -169,6 +178,7 @@ endif::add-copy-button-to-env-var[] a| [[quarkus-github-app_quarkus.github-app.debug.payload-directory]]`link:#quarkus-github-app_quarkus.github-app.debug.payload-directory[quarkus.github-app.debug.payload-directory]` + [.description] -- A directory in which the payloads are saved.