Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observability for streaming models #1081

Open
geoand opened this issue Nov 14, 2024 Discussed in #1080 · 3 comments
Open

Observability for streaming models #1081

geoand opened this issue Nov 14, 2024 Discussed in #1080 · 3 comments
Labels
enhancement New feature or request

Comments

@geoand
Copy link
Collaborator

geoand commented Nov 14, 2024

Discussed in #1080

Originally posted by cmasantos November 14, 2024
Hi, I've notice that "normal" chat model produce a set of gen_ai* metrics. But I've been unable to use them with streaming models. Also when we use a combination of Mutiny StreamingResponseHandler I'm almost sure that it can't be done.

My question is, how can I add metrics to a streaming model even if need to instantiate them? I've found the MetricsChatModelListener class but I can't find a way to put it together with the streaming model interface.

We should add observability for StreamingChatLanguageModel as well

@geoand geoand added the enhancement New feature or request label Nov 14, 2024
@geoand
Copy link
Collaborator Author

geoand commented Nov 14, 2024

@cmasantos would you be willing to contribute this feature?

@cmasantos
Copy link

@cmasantos would you be willing to contribute this feature?

Yes, I'd like to contribute. I'll give it a try, but it will take me a while because I have no idea how extensions development work. I've got to learn that first.

@geoand
Copy link
Collaborator Author

geoand commented Nov 15, 2024

Great!

In this case you probably don't need to learn too many details as the changes almost exactly match those that were made for ChatLanguageModel - I can certainly point you in the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants