Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for in-process embedding models #60

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Add support for in-process embedding models #60

merged 1 commit into from
Nov 24, 2023

Conversation

cescoffier
Copy link
Collaborator

@cescoffier cescoffier commented Nov 23, 2023 •
edited
Loading

  • Add management for in-process models
  • Fix native compilation when using in-process models
  • Write documentation

@cescoffier cescoffier changed the title Add support for in-process embedding model Add support for in-process embedding models Nov 23, 2023
@cescoffier
Copy link
Collaborator Author

Trying to see if my native fixes for on CI - Failing on my machine with "file too large"

@geoand
Copy link
Collaborator

geoand commented Nov 23, 2023

Cool!

@cescoffier cescoffier marked this pull request as ready for review November 23, 2023 17:05
@cescoffier cescoffier requested a review from a team as a code owner November 23, 2023 17:05
@cescoffier cescoffier requested a review from geoand November 23, 2023 17:06
geoand
geoand approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@geoand geoand merged commit c0f9314 into quarkiverse:main Nov 24, 2023
1 of 2 checks passed
@cescoffier cescoffier deleted the in-process-model branch November 24, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cescoffier @geoand