-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generateApis and generateModels options #839
base: main
Are you sure you want to change the base?
Conversation
Thanks @andybarilla nice contribution! Could you add a documentation about it? |
.../main/java/io/quarkiverse/openapi/generator/deployment/wrapper/QuarkusJavaClientCodegen.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkiverse/openapi/generator/deployment/wrapper/QuarkusJavaClientCodegen.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkiverse/openapi/generator/deployment/wrapper/QuarkusJavaClientCodegen.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkiverse/openapi/generator/deployment/wrapper/QuarkusJavaClientCodegen.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkiverse/openapi/generator/deployment/wrapper/QuarkusJavaClientCodegen.java
Outdated
Show resolved
Hide resolved
Docs have been added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andybarilla can you please add tests for both options?
...nt/src/test/java/io/quarkiverse/openapi/generator/deployment/OpenApiConfigValidatorTest.java
Show resolved
Hide resolved
@andybarilla did you had the chance to see my comments? |
Just saw them now. Yeah, I can add some integration tests. |
client/integration-tests/generate-flags/src/main/resources/application.properties
Show resolved
Hide resolved
LGTM. @andybarilla, could you please squash the commits? |
@hbelmiro anything else to add? |
"quarkus.openapi-generator.codegen.spec.spec_yaml.generate-apis=false", | ||
"quarkus.openapi-generator.codegen.spec.spec_yaml.generate-models=false", | ||
"quarkus.openapi-generator.codegen.spec.spec_yaml.generate-apis=true", | ||
"quarkus.openapi-generator.codegen.spec.spec_yaml.generate-models=true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These additions are no longer necessary, are they?
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
Fix #802
[0.9.x] Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2
to backport the original PR to thequarkus2
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.