Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generateApis and generateModels options #839

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andybarilla
Copy link

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

Fix #802

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@andybarilla andybarilla requested a review from a team as a code owner November 6, 2024 02:29
@mcruzdev
Copy link
Member

mcruzdev commented Nov 6, 2024

Thanks @andybarilla nice contribution! Could you add a documentation about it?

@andybarilla
Copy link
Author

Thanks @andybarilla nice contribution! Could you add a documentation about it?

Docs have been added

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andybarilla can you please add tests for both options?

@hbelmiro
Copy link
Contributor

@andybarilla did you had the chance to see my comments?

@andybarilla
Copy link
Author

@andybarilla did you had the chance to see my comments?

Just saw them now. Yeah, I can add some integration tests.

@mcruzdev
Copy link
Member

LGTM. @andybarilla, could you please squash the commits?

@ricardozanini
Copy link
Member

@hbelmiro anything else to add?

Comment on lines +22 to +25
"quarkus.openapi-generator.codegen.spec.spec_yaml.generate-apis=false",
"quarkus.openapi-generator.codegen.spec.spec_yaml.generate-models=false",
"quarkus.openapi-generator.codegen.spec.spec_yaml.generate-apis=true",
"quarkus.openapi-generator.codegen.spec.spec_yaml.generate-models=true",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These additions are no longer necessary, are they?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow enable/disable the API generation
5 participants