From 87ca9a9f6d22ec0d5e4b39590a06808c0d97da10 Mon Sep 17 00:00:00 2001 From: Robin David Date: Wed, 8 Nov 2023 11:46:48 +0100 Subject: [PATCH] replace wait() by communicate() to launch bindiff --- bindiff/bindiff.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bindiff/bindiff.py b/bindiff/bindiff.py index 2597ebc..e12fa43 100644 --- a/bindiff/bindiff.py +++ b/bindiff/bindiff.py @@ -180,7 +180,8 @@ def raw_diffing(p1_path: Union[Path, str], p2_path: Union[Path, str], out_diff: logging.debug(f"run diffing: {' '.join(cmd_line)}") process = subprocess.Popen(cmd_line, stdout=subprocess.PIPE, stderr=subprocess.PIPE) - retcode = process.wait() + out, err = process.communicate() + retcode = process.returncode if retcode != 0: logging.error(f"differ terminated with error code: {retcode}") return False