-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quarkus-resteasy-reactive as dev mode only dependency (for Dev UI) #1173
Comments
Why resteasy reactive ? You mean vertx-http to have enough for devmode ? I agree it would be nice to document This but doing it by default I'm not a fan off. @aloubyansky whats the maven equivalent of this feature? |
vertx-http should be enough. |
ah if vertx-http is enought, then I meant that. |
@aloubyansky what is the maven equivalent of gradles builddev dependency? |
There is no equivalent really. The closest scope would be |
Ok - that's what I thought. That's a shame. So the closest approach in maven would be to add vertx-http in a profile one can optionally enable when running devmode ? Wondering if could make it so that if certain property is set we would honor a profile with additional dependencies? |
We already have -Pnative for Maven. We could as well add -Pdev. |
So |
couldn't we keep |
No, that'll be too late. |
@aloubyansky can I close this? |
I guess we could still consider introducing |
Or maybe we should just document the workaround for this edge case? |
in quarkusio/quarkus#32396 we guide user to add the dependency. i think we should see if that is not sufficient rather than add yet-another profile to all projects. |
@aloubyansky actually; what would the -Pdev profile actually do in pom.xml ? would it be different or same from quarkusDev in gradle with respect to classloaders/dependency behavior? |
It could add dev mode-specific config, such as properties, dependencies, resource directories, etc. |
@aloubyansky I get that - but we would want as little extra needed in the build files hence I was curious what it would have? But more importantly is quarkusDev(gav) in gradle going to have any/signficant different behavior than -Pdev with maven when it comes classloading/dep behavior? |
It could define the default build goal, so the dev mode could be launched with
No, it would be the same. |
one downside of requiring profile here is that i.e. run from IDE's devmode would not see it. not sure if that's reason enough to not do it but it is something that would have to documented/explained as difference. |
Saw today in a Live-Demo by @kdubois where exactly this was the issue. |
As I was made aware today after raising this issue it's possible to add dependencies only for dev mode. It would be good if the code generator does that for everyone, that does not use
quarkus-resteasy
orquarkus-resteasy-reactive
.For gradle it would be a simple entry
The text was updated successfully, but these errors were encountered: