Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quarkus-resteasy-reactive as dev mode only dependency (for Dev UI) #1173

Open
bulldog98 opened this issue Mar 31, 2023 · 20 comments
Open
Labels

Comments

@bulldog98
Copy link

As I was made aware today after raising this issue it's possible to add dependencies only for dev mode. It would be good if the code generator does that for everyone, that does not use quarkus-resteasy or quarkus-resteasy-reactive.

For gradle it would be a simple entry

dependencies {
   // ...
   quarkusDev("io.quarkus:quarkus-resteasy-reactive") // or the non reactive what ever you think fits best
   // ...
}
@maxandersen
Copy link
Member

Why resteasy reactive ?

You mean vertx-http to have enough for devmode ?

I agree it would be nice to document This but doing it by default I'm not a fan off.

@aloubyansky whats the maven equivalent of this feature?

@aloubyansky
Copy link
Member

vertx-http should be enough.

@bulldog98
Copy link
Author

ah if vertx-http is enought, then I meant that.

@maxandersen
Copy link
Member

@aloubyansky what is the maven equivalent of gradles builddev dependency?

@aloubyansky
Copy link
Member

There is no equivalent really. The closest scope would be provided.

@maxandersen
Copy link
Member

Ok - that's what I thought.

That's a shame.

So the closest approach in maven would be to add vertx-http in a profile one can optionally enable when running devmode ?

Wondering if could make it so that if certain property is set we would honor a profile with additional dependencies?

@aloubyansky
Copy link
Member

We already have -Pnative for Maven. We could as well add -Pdev.

@aloubyansky
Copy link
Member

So mvn -Pdev would be enough to launch in dev mode

@ia3andy
Copy link
Collaborator

ia3andy commented Apr 3, 2023

So mvn -Pdev would be enough to launch in dev mode

couldn't we keep mvn quarkus:dev but make the dev profile active from the plugin itself?

@aloubyansky
Copy link
Member

No, that'll be too late.

@ia3andy
Copy link
Collaborator

ia3andy commented Jun 26, 2024

@aloubyansky can I close this?

@aloubyansky
Copy link
Member

I guess we could still consider introducing -Pdev profile in the generated projects.

@ia3andy
Copy link
Collaborator

ia3andy commented Jun 26, 2024

Or maybe we should just document the workaround for this edge case?

@maxandersen
Copy link
Member

in quarkusio/quarkus#32396 we guide user to add the dependency. i think we should see if that is not sufficient rather than add yet-another profile to all projects.

@maxandersen
Copy link
Member

@aloubyansky actually; what would the -Pdev profile actually do in pom.xml ? would it be different or same from quarkusDev in gradle with respect to classloaders/dependency behavior?

@aloubyansky
Copy link
Member

It could add dev mode-specific config, such as properties, dependencies, resource directories, etc.

@maxandersen
Copy link
Member

@aloubyansky I get that - but we would want as little extra needed in the build files hence I was curious what it would have?

But more importantly is quarkusDev(gav) in gradle going to have any/signficant different behavior than -Pdev with maven when it comes classloading/dep behavior?

@aloubyansky
Copy link
Member

@aloubyansky I get that - but we would want as little extra needed in the build files hence I was curious what it would have?

It could define the default build goal, so the dev mode could be launched with -Pdev (from the app module), and if we want to make sure quarkus-vertx-http is always around we would add it as a dependency in that profile.

But more importantly is quarkusDev(gav) in gradle going to have any/signficant different behavior than -Pdev with maven when it comes classloading/dep behavior?

No, it would be the same.

@maxandersen
Copy link
Member

one downside of requiring profile here is that i.e. run from IDE's devmode would not see it.

not sure if that's reason enough to not do it but it is something that would have to documented/explained as difference.

@bulldog98
Copy link
Author

Saw today in a Live-Demo by @kdubois where exactly this was the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants