From 64f613c3819867847cb7181ba17df4fb14c2601c Mon Sep 17 00:00:00 2001 From: Georgios Andrianakis Date: Thu, 13 Feb 2025 16:23:06 +0200 Subject: [PATCH] Apply minor polish to MongoClients --- .../quarkus/mongodb/runtime/MongoClients.java | 35 ++++++------------- 1 file changed, 10 insertions(+), 25 deletions(-) diff --git a/extensions/mongodb-client/runtime/src/main/java/io/quarkus/mongodb/runtime/MongoClients.java b/extensions/mongodb-client/runtime/src/main/java/io/quarkus/mongodb/runtime/MongoClients.java index 876ed9d8e9a78..bf9ccd0d53e69 100644 --- a/extensions/mongodb-client/runtime/src/main/java/io/quarkus/mongodb/runtime/MongoClients.java +++ b/extensions/mongodb-client/runtime/src/main/java/io/quarkus/mongodb/runtime/MongoClients.java @@ -139,7 +139,7 @@ public ClusterSettingBuilder(MongoClientConfig config) { this.config = config; } - private MongoClientConfig config; + private final MongoClientConfig config; @Override public void apply(ClusterSettings.Builder builder) { @@ -173,8 +173,8 @@ public ConnectionPoolSettingsBuilder(MongoClientConfig config, List connectionPoolListeners; + private final MongoClientConfig config; + private final List connectionPoolListeners; @Override public void apply(ConnectionPoolSettings.Builder builder) { @@ -204,8 +204,8 @@ public SslSettingsBuilder(MongoClientConfig config, boolean disableSslSupport) { this.disableSslSupport = disableSslSupport; } - private MongoClientConfig config; - private boolean disableSslSupport; + private final MongoClientConfig config; + private final boolean disableSslSupport; @Override public void apply(SslSettings.Builder builder) { @@ -218,7 +218,7 @@ public SocketSettingsBuilder(MongoClientConfig config) { this.config = config; } - private MongoClientConfig config; + private final MongoClientConfig config; @Override public void apply(SocketSettings.Builder builder) { @@ -236,7 +236,7 @@ public ServerSettingsBuilder(MongoClientConfig config) { this.config = config; } - private MongoClientConfig config; + private final MongoClientConfig config; @Override public void apply(ServerSettings.Builder builder) { @@ -439,8 +439,8 @@ private MongoCredential createMongoCredential(MongoClientConfig config) { usernamePassword = new UsernamePassword(null, null); } // Create the MongoCredential instance. - String username = usernamePassword.getUsername(); - char[] password = usernamePassword.getPassword(); + String username = usernamePassword.username(); + char[] password = usernamePassword.password(); MongoCredential credential; if (mechanism == GSSAPI) { credential = MongoCredential.createGSSAPICredential(username); @@ -513,21 +513,6 @@ public void stop() { } } - private static class UsernamePassword { - private final String username; - private final char[] password; - - public UsernamePassword(String username, char[] password) { - this.username = username; - this.password = password; - } - - public String getUsername() { - return username; - } - - public char[] getPassword() { - return password; - } + private record UsernamePassword(String username, char[] password) { } }