Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False negatives in CI marked as "Flakes" while running PR tests #44422

Open
Karm opened this issue Nov 11, 2024 · 1 comment
Open

False negatives in CI marked as "Flakes" while running PR tests #44422

Karm opened this issue Nov 11, 2024 · 1 comment
Assignees
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements kind/bug Something isn't working

Comments

@Karm
Copy link
Member

Karm commented Nov 11, 2024

Describe the bug

Hello,

While working on #44348 it has been bewildering to me that the CI was all green while locally it was broken.
The way the PR was done, it could not have passed, it was missing Brotli library loading, yet the CI was green 🟢

The reason seems to be that Errors are marked as "Flakes", because 2nd run PASSED:

2024-11-09T14:15:53.4363212Z [ERROR]   Run 1: RESTEndpointsIT>RESTEndpointsTest.testDecompressors:120 » UnsatisfiedLink 'java.nio.ByteBuffer com.aayushatharva.brotli4j.encoder.EncoderJNI.nativeCreate(long[])'
2024-11-09T14:15:53.4365271Z [INFO]    Run 2: PASS

Full: https://karms.biz/pastebin/errors-labeled-as-flakes.txt

It seems that the way Re-Run is configured, it recycles the whole context and the second time around, the Brotli4jLoader got called?

It might hide, as this case shows, important issues with integration tests. Can we take a step back and rather fix tests than to enable this re-run feature en mass?

How about we enable re-runs only for a subset of tests that are notorious for race conditions, e.g. some Mongo or DB or messaging scenarios.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

Linux amd64

Output of java -version

21

Quarkus version or git rev

main

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@Karm Karm added the kind/bug Something isn't working label Nov 11, 2024
@Karm Karm changed the title False negatives in CI while running PR tests False negatives in CI marked as "Flakes" while running PR tests Nov 11, 2024
@Karm
Copy link
Member Author

Karm commented Nov 11, 2024

@zakkak FYI ^^^

@geoand geoand added area/housekeeping Issue type for generalized tasks not related to bugs or enhancements and removed triage/needs-triage labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants