Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Jackson to 2.16.0 #37295

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Bump Jackson to 2.16.0 #37295

merged 3 commits into from
Dec 8, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Nov 24, 2023

Also includes the necessary bump aws xray to 2.15.0

Replaces #37188

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform area/vertx labels Nov 24, 2023
@geoand geoand requested a review from gsmet November 24, 2023 07:04
@gsmet gsmet changed the title Bump to 2.16.0 Bump Jackson to 2.16.0 Nov 24, 2023

This comment has been minimized.

@geoand
Copy link
Contributor Author

geoand commented Nov 24, 2023

The test failures are weird, I'll have to look more

@geoand
Copy link
Contributor Author

geoand commented Nov 24, 2023

Something seems to have changed with regards to registering modules in Jackson so I had to change JacksonRestClientTest a little

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Nov 24, 2023

The Amazon Lambda failure looks related, I haven't checked the other one:

2023-11-24T13:49:43.9940914Z Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.NoSuchFieldError: Class com.fasterxml.jackson.databind.PropertyNamingStrategy does not have member field 'com.fasterxml.jackson.databind.PropertyNamingStrategy CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES' [in thread "main"]
2023-11-24T13:49:43.9946911Z 	at com.amazonaws.xray.entities.EntityImpl.<clinit>(EntityImpl.java:61)
2023-11-24T13:49:43.9949717Z 	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized0(Native Method)
2023-11-24T13:49:43.9952615Z 	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized(Unsafe.java:1160)
2023-11-24T13:49:43.9957662Z 	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.classinitialization.ClassInitializationSupport.ensureClassInitialized(ClassInitializationSupport.java:177)
2023-11-24T13:49:43.9964443Z 	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.classinitialization.AllowAllHostedUsagesClassInitializationSupport.computeInitKindAndMaybeInitializeClass(AllowAllHostedUsagesClassInitializationSupport.java:191)
2023-11-24T13:49:43.9971636Z 	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.classinitialization.AllowAllHostedUsagesClassInitializationSupport.computeInitKindAndMaybeInitializeClass(AllowAllHostedUsagesClassInitializationSupport.java:160)
2023-11-24T13:49:44.0013183Z 	at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.classinitialization.AllowAllHostedUsagesClassInitializationSupport.computeInitKindAndMaybeInitializeClass(AllowAllHostedUsagesClassInitializationSupport.java:129)

@geoand
Copy link
Contributor Author

geoand commented Nov 24, 2023

Indeed.

I'm going to tap out of this one however as I will be traveling next week

@gsmet
Copy link
Member

gsmet commented Nov 27, 2023

I think we will have to wait for X-Ray to adapt. The problem is caused by this commit in Jackson: FasterXML/jackson-databind@d7a1efc .

@gsmet
Copy link
Member

gsmet commented Nov 27, 2023

The MySQL one is related to a Quay issue so not concerning.

@geoand
Copy link
Contributor Author

geoand commented Nov 27, 2023

Ah, nice catch!

@msailes is the X-RAY something you can help push forward on your side?

Thanks 🙏

@msailes
Copy link
Contributor

msailes commented Nov 27, 2023

@wangzlei, is this a change X-Ray plans to make?

@manofthepeace
Copy link
Contributor

Created this in the hope I can help a bit where I can.. aws/aws-xray-sdk-java#391

@wangzlei
Copy link

wangzlei commented Dec 1, 2023

Thanks for providing aws/aws-xray-sdk-java#391, we would release a minor version with this fix next week.

@geoand
Copy link
Contributor Author

geoand commented Dec 1, 2023

Great, thanks!

@geoand geoand added area/jackson Issues related to Jackson (JSON library) triage/waiting-for-ci Ready to merge when CI successfully finishes and removed area/vertx area/platform Issues related to definition and interaction with Quarkus Platform area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Dec 8, 2023
Copy link

quarkus-bot bot commented Dec 8, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot, thanks!

@gsmet gsmet merged commit cea1344 into quarkusio:main Dec 8, 2023
49 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 8, 2023
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 8, 2023
@gsmet
Copy link
Member

gsmet commented Dec 8, 2023

@manofthepeace @wangzlei thanks for your help in getting this in!

@geoand geoand deleted the jackson-2.16 branch December 8, 2023 10:24
@gsmet
Copy link
Member

gsmet commented Dec 8, 2023

Oh and thanks @msailes for pinging the right person, it helped too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jackson Issues related to Jackson (JSON library)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants