-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Jackson to 2.16.0 #37295
Bump Jackson to 2.16.0 #37295
Conversation
This comment has been minimized.
This comment has been minimized.
The test failures are weird, I'll have to look more |
Something seems to have changed with regards to registering modules in Jackson so I had to change |
This comment has been minimized.
This comment has been minimized.
The Amazon Lambda failure looks related, I haven't checked the other one:
|
Indeed. I'm going to tap out of this one however as I will be traveling next week |
I think we will have to wait for X-Ray to adapt. The problem is caused by this commit in Jackson: FasterXML/jackson-databind@d7a1efc . |
The MySQL one is related to a Quay issue so not concerning. |
Ah, nice catch! @msailes is the X-RAY something you can help push forward on your side? Thanks 🙏 |
@wangzlei, is this a change X-Ray plans to make? |
Created this in the hope I can help a bit where I can.. aws/aws-xray-sdk-java#391 |
Thanks for providing aws/aws-xray-sdk-java#391, we would release a minor version with this fix next week. |
Great, thanks! |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot, thanks!
@manofthepeace @wangzlei thanks for your help in getting this in! |
Oh and thanks @msailes for pinging the right person, it helped too! |
Also includes the necessary bump aws xray to 2.15.0
Replaces #37188