Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide sensible, default-enabled channel configurations #235

Open
ryan-summers opened this issue Oct 10, 2022 · 5 comments
Open

Provide sensible, default-enabled channel configurations #235

ryan-summers opened this issue Oct 10, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@ryan-summers
Copy link
Member

Currently, Booster keeps everything disabled by default until a channel is configured via the MQTT broker. While this safe, it can result in an unsatisfying user experience where Booster does not do anything out-of-the-box until it is connected to the MQTT broker and configured.

I twould be useful to provide sensible default configurations for Booster channels such that they are enabled by default.

@ryan-summers ryan-summers added the enhancement New feature or request label Oct 10, 2022
@ryan-summers
Copy link
Member Author

It's unclear to me what sensible defaults would be for the bias DAC setting. Some options:

  1. Default bias DAC to pinch-off. The channel would appear enabled via the front-panel, but the RF output would effectively be disabled
    • Seems like a bad idea as it may mislead the user to thinking the channel is operational
  2. Take a measurement of some low-power output level on one Booster and use that bias DAC level as a default for all devices
    • It's unknown how reliable a single bias DAC level is for a range of devices, so this could potentially result in higher- or lower-than-aniticpated output power levels on new devices.

@jordens
Copy link
Member

jordens commented Oct 10, 2022

I don't see a way either to do it without valid settings. The best we can do is the following:

If there are valid settings (hence a calibrated bias voltage), and if the settings do not indicate that the channel should remain off, use that voltage and turn on the channel.

With that it will work without broker once the user has set up the bias voltage on a channel once and saved the settings.
Let's also make sure that in this case the default settings are such that the channel is on.

@ryan-summers
Copy link
Member Author

If there are valid settings (hence a calibrated bias voltage), and if the settings do not indicate that the channel should remain off, use that voltage and turn on the channel.

This is already the current behavior. If the channel is saved in an "Active" state, it will power-on by default at power-up, but this still necessitates using a broker once for initial setup

@ryan-summers
Copy link
Member Author

Closing as resolved. It's not clear that we should have different default settings than what already exist.

@ryan-summers
Copy link
Member Author

ryan-summers commented Dec 7, 2022

Reopening this. We discussed that there's interest from Creotech in either:

  1. Figure out a good default from basic-principals (i.e. review hardware, determine valid set point, analyze results)
  2. Provide a manufacturing-time provisioning step where each channel is tuned to a specified bias current

This would allow shipment of boosters in a default usable state without the owner having to set up any MQTT broker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants