In Quarto website and probably book, when there is navbar for a page with a sidebar, the active nav is not the right one.

See below for Quarto Web - the CSS for active link being blue shows the overview is always selected

This was reported by @AshleyHenry15

This was tricky to debug, but this is because:

We do set the active nav based on some sidebar finding and href comparaison

but this has been broken by the fact the sidebar may have a logo with a link:

This part of the template is activated now always because sidebar.logo has been normalized in

• feature: light and dark logo #12996
  and it is no more undefined

{
  light: undefined,
  dark: undefined,
}

So if(sidebar.logo) is always true and this creates some HTML that are not expected in the page

<!-- sidebar -->
  <nav id="quarto-sidebar" class="sidebar collapse collapse-horizontal quarto-sidebar-collapse-item sidebar-navigation floating overflow-auto">
    <div class="pt-lg-2 mt-2 text-left sidebar-header sidebar-header-stacked">
      <a href="./index.html" class="sidebar-logo-link">
      </a>
      </div>

which messes up with the search

hence the .active class not being set on the right nav.

So

• We can't test if(sidebar.logo) anymore, as it seems it won't be undefined but sidebar.logo.light and sidebar.logo.dark will
• We probably need to protect the search for avoid selecting the link inside the logo part.

This is a regression and we'll need to backport.