-
Notifications
You must be signed in to change notification settings - Fork 388
Open
Labels
enhancementNew feature or requestNew feature or requestwebsite-navigationwebsitesIssues creating websitesIssues creating websites
Description
While looking at fixing an issue with sidebar, it happens logo can be define only in one mode of navigation. Maybe it would be worth supporting for hybrid navigation.
- Either one logo for all
- Or one logo per sidebar
As discussed, we are only resolving the logos in sidebars[0], but we should probably resolve logos in all sidebars:
quarto-cli/src/project/types/website/website-shared.ts
Lines 174 to 208 in 4262320
| let sideLogo = sidebars[0].logo; | |
| if (sideLogo) { | |
| if (sidebars[0][kLogoAlt]) { | |
| const alt = sidebars[0][kLogoAlt]; | |
| if (typeof sideLogo === "string") { | |
| sideLogo = { path: sideLogo, alt }; | |
| } | |
| // possible but absurd | |
| // else if ("path" in sideLogo) { | |
| // sideLogo = { ...sideLogo, alt }; | |
| // } else { | |
| // sideLogo = { | |
| // light: !sideLogo.light ? undefined : typeof sideLogo.light === "string" | |
| // ? { | |
| // path: sideLogo.light, | |
| // alt, | |
| // } | |
| // : { ...sideLogo.light, alt }, | |
| // dark: !sideLogo.dark ? undefined : typeof sideLogo.dark === "string" | |
| // ? { | |
| // path: sideLogo.dark, | |
| // alt, | |
| // } | |
| // : { ...sideLogo.dark, alt }, | |
| // }; | |
| // } | |
| } | |
| } | |
| let logo = resolveLogo(projectBrand, sideLogo, [ | |
| "medium", | |
| "small", | |
| "large", | |
| ]); | |
| logo = logoAddLeadingSlashes(logo, projectBrand, undefined); | |
| sidebars[0].logo = logo; |
Originally posted by @gordonwoodhull in #13507 (comment)
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestwebsite-navigationwebsitesIssues creating websitesIssues creating websites