-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate winget release #1
Comments
FWIW,
Third option/workaround: only provide user scope in the manifest (until this is solved) and automate. |
For some reason, I couldn't because the second time I passed the URL it tolds me that the file is locked.
I thought about that, but it seems that it was added for a reason, was it ? |
Yes, I thought it would be better to make the scope more explicit, see quarto-dev/quarto-cli#1977. When it is not defined, the scope seems to be "it depends". If that is not a problem (AFAICT it isn't) just revert to non-scoped installer. I am not sure if it is possible to submit manifests with user-scope only (in case this would be preferable from your/quarto's POV). But might be worth a shot.
Haven't had that kind of problem and have been using this for a year now. Is the repo on a network drive or OneDrive? Or maybe a virus scanner is hitting the installer file in the winget cache at the same time (in temp dir, I assume). |
I'll look into that. Thanks ! |
Meaning: Make it possible to choose the scope on installation with winget. |
We should have a closer look at latest version of https://github.com/vedantmgoyal2009/winget-releaser see quarto-dev/quarto-cli#3334 (comment) suggestion by @russellbanks We need to check if it handles the two scopes with same url correctly |
From quarto-dev/quarto-cli#3334 (comment):
WinGet Releaser can handle this; it will just use the same URL twice.
WinGet Releaser would run on release (ignoring any draft or pre-release releases) (other events can be used if needed though): on:
release:
types: [released] |
See microsoft/winget-pkgs#88822 as an example of WinGet Releaser handling two scopes with the same url correctly. |
Awesome thank you @russellbanks ! |
Would be good to note VSCodium (with their insider channel) has done a similar thing here, where they have their releases kept in a separate repository to where their workflow is. See vedantmgoyal9/winget-releaser#21 This is possible with the This is their workflow, for reference. |
Yes this was my plan once we decide to automate the release on winget from release from CLI. Currently, it is a choice to have it manually trigger release on Winget and Chocolatey. |
Interesting new project to look at: https://github.com/russellbanks/Komac found in microsoft/winget-pkgs#500 |
With WinGet-Create 1.2.6.0 there should not be any issue more as these are solved |
So I wanted to wait for this release, and see if there was new stuff. And it seems they do update automatically now 🎉 Or maybe it was manual but it says
So it seems this is handled by the community - maybe at some point we can do the work to automate like chocolatey, but it seems this is available quickly with current process. That is cool ! |
https://github.com/sharkdp/bat/blob/196a4cb18f3be9b5a04e47a07bc3d3299158b0fb/.github/workflows/CICD.yml#L456-L466 |
Process needs to be manual because
wingetcreate
can't be use due to limitation as we are using two scope in our manifest with one url. See microsoft/winget-create#166 and microsoft/winget-create#291 (cc @dpprdan)Also, it can't be used interactively either due to this.
For now, I am doing manual update using YAMLCreate.ps1 in
winget-pks
repo.We could try modifying the manifests manually to automate, but probably more work than doing update manually, until they solve the issue.
The text was updated successfully, but these errors were encountered: