Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Feature request: different icons per mode/platform #91

Closed
GordonBlahut opened this issue Sep 11, 2019 · 5 comments
Closed

Feature request: different icons per mode/platform #91

GordonBlahut opened this issue Sep 11, 2019 · 5 comments

Comments

@GordonBlahut
Copy link

For my SPA and Android app I might want an icon with rounded edges, but since iOS already forces all icons to have rounded edges, this can lead to some conflicts if the icon provided has transparency at the edges or the rounding used is larger than Apple's. Or I may just want to make my icons better match platform-specific aesthetic.

Basically, the ability to provide source icons like app-icon.cordova.ios.png, app-icon.cordova.android.png, etc. with fallback to app-icon.png if a platform/mode-specific icon isn't provided.

@GordonBlahut
Copy link
Author

Actually, rather than specific icon names, allow devs to set the source icon paths/names in quasar.conf.js. That way we can use any logic we want (e.g. checking ctx.dev, ctx.mode.cordova, ctx.targetName, etc.) to set the source icons. That way any variations could be accommodated like if someone wanted a different icon for dev vs build.

The cached hash for icons would probably have to be keyed by the file name/path.

@spike-bepop
Copy link

allow devs to set the source icon paths/names in quasar.conf.js

+1

@Nigui
Copy link

Nigui commented Mar 31, 2020

+1 👍

@hawkeye64
Copy link
Member

@GordonBlahut @evazc @Nigui Check this out for a reply: #108 (comment)

@rstoenescu
Copy link
Member

This will be available with the complete rewrite of Icon Genie v2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants